Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dataconnect: Add OrderDirection codegen integration test #6308

Merged
merged 9 commits into from
Sep 30, 2024

Conversation

dconeybe
Copy link
Contributor

@dconeybe dconeybe commented Sep 25, 2024

Note: OrderDirection support was added in a previous PR: #6307

@dconeybe
Copy link
Contributor Author

This PR cannot be merged until the Data Connect Toolkit is released with OrderDirection enum support in Android codegen. Googlers can see cl/678576815. At the time of writing, the latest version of the Data Connect Toolkit is 1.3.9 (released Sept 24, 2024); therefore, this PR cannot be merged until v1.3.10 (or later) is released and the gradle plugin is updated with knowledge of 1.3.10.

Copy link
Contributor

github-actions bot commented Sep 25, 2024

Unit Test Results

  48 files   -      955    48 suites   - 955   1m 21s ⏱️ - 35m 5s
484 tests  -   5 326  484 ✔️  -   5 304  0 💤  - 21  0  - 1 
968 runs   - 10 584  968 ✔️  - 10 541  0 💤  - 42  0  - 1 

Results for commit d702b2d. ± Comparison against base commit bf1f1fe.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 25, 2024

Coverage Report 1

Affected Products

No changes between base commit (552132b) and merge commit (8570c62).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/nPqWs32osV.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 25, 2024

@dconeybe dconeybe force-pushed the dconeybe/dataconnect/OrderDirection branch from 7440ec6 to 128b537 Compare September 25, 2024 16:35
Base automatically changed from dconeybe/dataconnect/OrderDirection to main September 25, 2024 16:45
@dconeybe dconeybe closed this Sep 25, 2024
@dconeybe dconeybe force-pushed the dconeybe/dataconnect/OrderDirectionConnectorsTest branch from b7f9d73 to 552132b Compare September 25, 2024 17:14
@dconeybe dconeybe reopened this Sep 25, 2024
@dconeybe dconeybe changed the title Add OrderDirection codegen integration test dataconnect: Add OrderDirection codegen integration test Sep 25, 2024
Copy link
Contributor

github-actions bot commented Sep 25, 2024

Release note changes

No release note changes were detected. If you made changes that should be
present in the next release, ensure you've added an entry in the appropriate
CHANGELOG.md file(s).

@dconeybe dconeybe merged commit 034566e into main Sep 30, 2024
36 checks passed
@dconeybe dconeybe deleted the dconeybe/dataconnect/OrderDirectionConnectorsTest branch September 30, 2024 18:42
@firebase firebase locked and limited conversation to collaborators Oct 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants