Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IllegalStateException when starting a trace before Firebase init #6371

Merged
merged 3 commits into from
Oct 11, 2024

Conversation

mrober
Copy link
Contributor

@mrober mrober commented Oct 10, 2024

Fix IllegalStateException when starting a trace before Firebase initializes.

This can happen if you manually initialize Firebase. See #4693

Copy link
Contributor

github-actions bot commented Oct 10, 2024

Release note changes

The following release notes were modified. Please ensure they look correct.

Release Notes
firebase-perf
### {{perfmon}} version 21.0.2 {: #performance_v21-0-2}

* {{fixed}} Fix IllegalStateException when starting a trace before Firebase initializes.

* {{changed}} Updated protobuf dependency to `3.25.5` to fix
  [CVE-2024-7254](https://github.com/advisories/GHSA-735f-pc8j-v9w8).

#### {{perfmon}} Kotlin extensions version 21.0.2 {: #performance-ktx_v21-0-2}

The Kotlin extensions library transitively includes the updated
`firebase-perf` library. The Kotlin extensions library has no additional
updates.

@mrober mrober enabled auto-merge (squash) October 10, 2024 20:10
# Conflicts:
#	firebase-perf/CHANGELOG.md
Copy link
Contributor

Test Results

  110 files   -  76    110 suites   - 76   2m 18s ⏱️ - 2m 18s
  968 tests  - 266    968 ✅  - 250  0 💤  - 16  0 ❌ ±0 
1 944 runs   - 548  1 944 ✅  - 516  0 💤  - 32  0 ❌ ±0 

Results for commit 1edae57. ± Comparison against base commit 60a5e4c.

This pull request removes 1234 and adds 968 tests. Note that renamed tests count towards both.
com.google.firebase.firestore.AggregateQuerySnapshotTest ‑ createWithCountShouldReturnInstanceWithTheGivenQueryAndCount
com.google.firebase.firestore.AggregateQueryTest ‑ testSourceMustNotBeNull
com.google.firebase.firestore.BlobTest ‑ testComparison
com.google.firebase.firestore.BlobTest ‑ testEquals
com.google.firebase.firestore.BlobTest ‑ testMutableBytes
com.google.firebase.firestore.CollectionReferenceTest ‑ testEquals
com.google.firebase.firestore.DocumentChangeTest ‑ randomTests
com.google.firebase.firestore.DocumentChangeTest ‑ testAdditions
com.google.firebase.firestore.DocumentChangeTest ‑ testChangesWithSortOrderChange
com.google.firebase.firestore.DocumentChangeTest ‑ testDeletions
…
com.google.firebase.perf.FirebasePerfRegistrarTest ‑ testGetComponents
com.google.firebase.perf.FirebasePerformanceTest ‑ firebasePerformanceInitialization_providesRcProvider_remoteConfigManagerIsSet
com.google.firebase.perf.FirebasePerformanceTest ‑ initFirebasePerformance_injectsMetadataIntoConfigResolver
com.google.firebase.perf.FirebasePerformanceTest ‑ initializeFirebasePerformance_emptyMetadataAndCache_metadataAndContextInjected
com.google.firebase.perf.FirebasePerformanceTest ‑ setDataCollectionDefaultEnabled_whenForceDisabledThenCleared_respectsGlobalFlag
com.google.firebase.perf.FirebasePerformanceTest ‑ setDataCollectionDefaultEnabled_whenForceDisabledThenCleared_respectsManifestTrue
com.google.firebase.perf.FirebasePerformanceTest ‑ setDataCollectionDefaultEnabled_whenForceEnabledThenCleared_respectsGlobalFlag
com.google.firebase.perf.FirebasePerformanceTest ‑ setDataCollectionDefaultEnabled_whenForceEnabledThenCleared_respectsManifestFalse
com.google.firebase.perf.FirebasePerformanceTest ‑ testAddingMoreThanMaxLocalAttributes
com.google.firebase.perf.FirebasePerformanceTest ‑ testBothManifestsAgree
…

@mrober mrober merged commit 8869a14 into main Oct 11, 2024
31 checks passed
@mrober mrober deleted the perf-trace-before-init branch October 11, 2024 19:01
@firebase firebase locked and limited conversation to collaborators Nov 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants