dataconnect: TestFirebaseAppFactory.kt: work around IllegalStateException in tests by adding a delay before calling FirebaseApp.delete() #6447
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a race condition in the Data Connect tests where if a
FirebaseApp
is deleted very shortly after creating it then an IllegalStateException can be thrown, crashing the test app entirely, resulting in a flaky test.The "fix" is really a "workaround", in that it waits for 1 second before calling
FirebaseApp.delete()
to minimize the chances that the FirebaseAuth worker thread will try to access the deleted FirebaseApp instance. Googlers see b/378116261 for details.The crash fixed by this PR looks like this: