Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dataconnect: DateScalarIntegrationTest.kt rewritten #6515

Merged

Conversation

dconeybe
Copy link
Contributor

This PR rewrites DateScalarIntegrationTest.kt to use the new date-testing facilities added by the unit and integration tests for the new LocalDate class.

Copy link
Contributor

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_responses.sh should be updated to clone the latest version of the responses: v5.2

Copy link
Contributor

github-actions bot commented Nov 14, 2024

Test Results

   58 files  ±0     58 suites  ±0   2m 4s ⏱️ -2s
  535 tests ±0    534 ✅ ±0  1 💤 ±0  0 ❌ ±0 
1 070 runs  ±0  1 068 ✅ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit a139ac1. ± Comparison against base commit c87f103.

♻️ This comment has been updated with latest results.

Base automatically changed from dconeybe/dataconnect/DateSerializerDeletion to main November 14, 2024 21:10
@dconeybe dconeybe force-pushed the dconeybe/dataconnect/DateScalarIntegrationTestRewrite branch from 990c43a to a139ac1 Compare November 14, 2024 21:13
Copy link
Contributor

Release note changes

No release note changes were detected. If you made changes that should be
present in the next release, ensure you've added an entry in the appropriate
CHANGELOG.md file(s).

@dconeybe dconeybe merged commit 9299c6d into main Nov 14, 2024
36 checks passed
@dconeybe dconeybe deleted the dconeybe/dataconnect/DateScalarIntegrationTestRewrite branch November 14, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants