Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use version catalog for encoders #6570

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Use version catalog for encoders #6570

merged 1 commit into from
Dec 6, 2024

Conversation

rlazo
Copy link
Collaborator

@rlazo rlazo commented Dec 6, 2024

No description provided.

@rlazo rlazo requested review from daymxn and davidmotson December 6, 2024 18:33
Copy link
Contributor

github-actions bot commented Dec 6, 2024

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

Copy link
Contributor

github-actions bot commented Dec 6, 2024

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_responses.sh should be updated to clone the latest version of the responses: v5.2

Copy link
Contributor

github-actions bot commented Dec 6, 2024

Test Results

10 files   -  1 026  10 suites   - 1 026   25s ⏱️ - 32m 48s
56 tests  -  5 817  56 ✅  -  5 795  0 💤  - 22  0 ❌ ±0 
99 runs   - 11 732  99 ✅  - 11 688  0 💤  - 44  0 ❌ ±0 

Results for commit a378165. ± Comparison against base commit 6021b75.

This pull request removes 5817 tests.
com.google.android.datatransport.cct.CctBackendFactoryTest ‑ create_returnCCTBackend_WhenBackendNameIsCCT
com.google.android.datatransport.cct.CctDestinationTest ‑ cctDestination_shouldOnlySupportProtoAndJson
com.google.android.datatransport.cct.CctDestinationTest ‑ cctDestination_shouldSupportProtoAndJson
com.google.android.datatransport.cct.CctTransportBackendTest ‑ decorate_whenOffline_shouldProperlyPopulateNetworkInfo
com.google.android.datatransport.cct.CctTransportBackendTest ‑ decorate_whenOnline_shouldProperlyPopulateNetworkInfo
com.google.android.datatransport.cct.CctTransportBackendTest ‑ schedule_shouldAddCookieOnPseudonymousIds
com.google.android.datatransport.cct.CctTransportBackendTest ‑ schedule_shouldDropCookieOnMixedPseudonymousIds
com.google.android.datatransport.cct.CctTransportBackendTest ‑ send_CompressedResponseIsUncompressed
com.google.android.datatransport.cct.CctTransportBackendTest ‑ send_whenBackendRedirectsMoreThan5Times_shouldOnlyRedirect4Times
com.google.android.datatransport.cct.CctTransportBackendTest ‑ send_whenBackendRedirects_shouldCorrectlyFollowTheRedirectViaPost
…

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • firebase-decoders-json

    TypeBase (6021b75)Merge (edeb13c)Diff
    apk (aggressive)9.38 kB20.6 kB+11.2 kB (+119.9%)
    apk (release)26.5 kB2.01 MB+1.99 MB (+7502.5%)
  • firebase-encoders

    TypeBase (6021b75)Merge (edeb13c)Diff
    apk (aggressive)9.38 kB20.6 kB+11.2 kB (+119.9%)
    apk (release)27.2 kB2.01 MB+1.99 MB (+7299.2%)
  • firebase-encoders-json

    TypeBase (6021b75)Merge (edeb13c)Diff
    apk (release)2.01 MB2.02 MB+11.2 kB (+0.6%)
  • firebase-encoders-reflective

    TypeBase (6021b75)Merge (edeb13c)Diff
    apk (aggressive)9.75 kB21.0 kB+11.3 kB (+115.4%)
    apk (release)42.6 kB2.03 MB+1.99 MB (+4665.3%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Myo9grI8aq.html

@rlazo rlazo merged commit bbb2214 into main Dec 6, 2024
43 of 44 checks passed
@rlazo rlazo deleted the rl.version.catalog.encoders branch December 6, 2024 18:45
@firebase firebase locked and limited conversation to collaborators Jan 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants