-
Notifications
You must be signed in to change notification settings - Fork 598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dataconnect: Improve usage of MutableStateFlow to improve readability #6840
Draft
dconeybe
wants to merge
12
commits into
main
Choose a base branch
from
dconeybe/dataconnect/MutableStateFlowUseUpdateInsteadOfCompareAndSet
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
dataconnect: Improve usage of MutableStateFlow to improve readability #6840
dconeybe
wants to merge
12
commits into
main
from
dconeybe/dataconnect/MutableStateFlowUseUpdateInsteadOfCompareAndSet
+90
−103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f AtomicReference
Loading status checks…
…DataConnect.awaitAuthReady() and FirebaseDataConnect.awaitAppCheckReady()
Loading status checks…
Loading status checks…
…w.compareAndSet() directly for improved readability and less potential for bugs
Coverage Report 1Affected Products
Test Logs |
Test Results 66 files + 48 66 suites +48 1m 20s ⏱️ + 1m 6s Results for commit c9d70a3. ± Comparison against base commit d7a56a1. This pull request removes 86 and adds 552 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Size Report 1Affected Products
Test Logs |
Loading status checks…
Loading status checks…
…aconnect/MutableStateFlowUseUpdateInsteadOfCompareAndSet
Loading status checks…
…dateInsteadOfCompareAndSet
Loading status checks…
…dateInsteadOfCompareAndSet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use MutableStateFlow.update() instead of MutableStateFlow.compareAndSet() directly for improved readability and less potential for bugs