Add unit tests for new logging in GaugeManager using GaugeCounter. #6953
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report 1Affected Products
Test Logs |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Test Results 110 files 110 suites 2m 9s ⏱️ Results for commit 9ce45e7. ♻️ This comment has been updated with latest results. |
Size Report 1Affected Products
Test Logs |
mrober
reviewed
May 14, 2025
| private val gaugeManager: GaugeManager = GaugeManager.getInstance() | ||
| private val logger = AndroidLogger.getInstance() | ||
| // TODO(b/394127311): Setting this as a var for a unit test. Refactor it. | ||
| var gaugeManager: GaugeManager = GaugeManager.getInstance() |
There was a problem hiding this comment.
You could do something like:
var gaugeManager: ...
internal setThere was a problem hiding this comment.
And maybe even @set:VisibleForTesting?
mrober
reviewed
May 14, 2025
| import org.robolectric.shadows.ShadowPackageManager; | ||
|
|
||
| public class FirebasePerformanceTestBase { | ||
| @BeforeClass |
There was a problem hiding this comment.
Can you do it @After instead? Then be a good citizen to other unit tests in the future
There was a problem hiding this comment.
For some reason the unit tests fails on Github Actions (but not locally) with @After. Reverted it and added a TODO.
mrober
approved these changes
May 14, 2025
tejasd
added a commit
that referenced
this pull request
May 15, 2025
…6953) - Fixes relevant unit tests - specifically requiring a definite `ApplicationProcessState` - Adds new unit tests for the updated behaviour - Deletes unit tests that *should* be OK to delete.
tejasd
added a commit
that referenced
this pull request
May 23, 2025
…6953) - Fixes relevant unit tests - specifically requiring a definite `ApplicationProcessState` - Adds new unit tests for the updated behaviour - Deletes unit tests that *should* be OK to delete.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ApplicationProcessState