Skip to content

Commit

Permalink
Update upload download artifacts to v4
Browse files Browse the repository at this point in the history
  • Loading branch information
@a-maurice
a-maurice committed Nov 7, 2024
1 parent ed3f87b commit 82d0e81
Show file tree
Hide file tree
Showing 3 changed files with 90 additions and 85 deletions.
48 changes: 26 additions & 22 deletions .github/workflows/cpp-packaging.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ jobs:
tar -czhf ../packaging-tools.tgz .
- name: upload artifacts
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: packaging-tools-${{ matrix.tools_platform }}
path: packaging-tools.tgz
Expand Down Expand Up @@ -236,7 +236,7 @@ jobs:
find firebase-cpp-sdk-*-package -type f
- name: upload artifacts
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: firebase-cpp-sdk-ios-tvos-package
path: firebase-cpp-sdk-ios-tvos-package.tgz
Expand Down Expand Up @@ -296,7 +296,7 @@ jobs:
find firebase-cpp-sdk-*-package -type f
- name: upload artifacts
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: firebase-cpp-sdk-android-package
path: firebase-cpp-sdk-android-package.tgz
Expand Down Expand Up @@ -450,7 +450,7 @@ jobs:
continue-on-error: true

- name: upload artifacts
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: firebase-cpp-sdk-${{ env.SDK_NAME }}-build
path: firebase-cpp-sdk-${{ env.SDK_NAME }}-build.tgz
Expand Down Expand Up @@ -509,12 +509,17 @@ jobs:
with:
path: sdk-src

- name: download artifact
uses: actions/download-artifact@v3
- name: download packaging-tool artifacts
uses: actions/download-artifact@v4
with:
path: artifacts
pattern: packaging-tools-*

- name: download build artifacts
uses: actions/download-artifact@v4
with:
# download-artifact doesn't support wildcards, but by default
# will download all artifacts. Sadly this is what we must do.
path: artifacts
pattern: firebase-cpp-sdk-*

- name: Setup python
uses: actions/setup-python@v4
Expand Down Expand Up @@ -586,7 +591,7 @@ jobs:
find firebase-cpp-sdk-*-package -type f
- name: upload SDK zip
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: firebase-cpp-sdk-${{ matrix.sdk_platform }}${{ matrix.suffix}}-package
path: firebase-cpp-sdk-${{ matrix.sdk_platform }}${{ matrix.suffix}}-package.tgz
Expand Down Expand Up @@ -656,12 +661,12 @@ jobs:
if: ${{ github.event.inputs.downloadPublicVersion != '' || github.event.inputs.downloadPreviousRun != '' }}
steps:
- name: fetch artifact from previous run
uses: dawidd6/action-download-artifact@v2
uses: actions/download-artifact@v4
if: ${{ github.event.inputs.downloadPreviousRun != '' }}
with:
name: 'firebase_cpp_sdk.zip'
workflow: 'cpp-packaging.yml'
run_id: ${{ github.event.inputs.downloadPreviousRun }}
github-token: ${{ github.token }}
run-id: ${{ github.event.inputs.downloadPreviousRun }}

- name: fetch public SDK package from web
if: ${{ github.event.inputs.downloadPublicVersion != '' && github.event.inputs.downloadPreviousRun == '' }}
Expand All @@ -687,13 +692,13 @@ jobs:
echo "::warning ::$(cat firebase_cpp_sdk_hash.txt)"
- name: upload hash
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: firebase_cpp_sdk_hash.txt
path: firebase_cpp_sdk_hash.txt

- name: upload SDK zip
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: firebase_cpp_sdk.zip
path: firebase_cpp_sdk.zip
Expand All @@ -711,11 +716,10 @@ jobs:
path: sdk-src

- name: download artifact
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
# download-artifact doesn't support wildcards, but by default
# will download all artifacts. Sadly this is what we must do.
path: artifacts
pattern: firebase-cpp-sdk-*-package

- name: merge SDK packages
shell: bash
Expand Down Expand Up @@ -750,13 +754,13 @@ jobs:
find firebase_cpp_sdk -type f
- name: upload hash
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: firebase_cpp_sdk_hash.txt
path: firebase_cpp_sdk_hash.txt

- name: upload SDK zip
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: firebase_cpp_sdk.zip
path: firebase_cpp_sdk.zip
Expand All @@ -767,7 +771,7 @@ jobs:
needs: [merge_packages]
steps:
- name: download SDK zip
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: firebase_cpp_sdk.zip
- name: unzip SDK and remove non-Windows files
Expand Down Expand Up @@ -795,12 +799,12 @@ jobs:
${{ env.hashCommand }} --tag firebase_cpp_sdk_windows.zip > firebase_cpp_sdk_windows_hash.txt
echo "::warning ::$(cat firebase_cpp_sdk_windows_hash.txt)"
- name: upload Windows hash
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: firebase_cpp_sdk_windows_hash.txt
path: firebase_cpp_sdk_windows_hash.txt
- name: upload Windows SDK zip
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: firebase_cpp_sdk_windows.zip
path: firebase_cpp_sdk_windows.zip
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/desktop.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ jobs:
sudo chmod -R +rwx ~/Library/Logs/DiagnosticReports/* || :
- name: Archive crashes and binaries (linux)
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
if: failure() && startsWith(matrix.build_type, 'Debug') && startsWith(matrix.os, 'ubuntu')
with:
name: crashes-${{ matrix.os }}-${{ matrix.build_type }}-${{ matrix.architecture }}-${{ matrix.python_version }}
Expand All @@ -279,7 +279,7 @@ jobs:
/tmp/bins/*
- name: Archive crashes (mac)
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
if: failure() && startsWith(matrix.build_type, 'Debug') && startsWith(matrix.os, 'macos')
with:
name: crashes-${{ matrix.os }}-${{ matrix.build_type }}-${{ matrix.architecture }}-${{ matrix.python_version }}-${{ matrix.xcode_version }}
Expand Down
Loading

0 comments on commit 82d0e81

Please sign in to comment.