Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement ObjectArena and ArenaRef to solve JNI Global Reference Issue #1145

Closed
wants to merge 10 commits into from
Closed

Implement ObjectArena and ArenaRef to solve JNI Global Reference Issue #1145

wants to merge 10 commits into from

Conversation

cherylEnkidu
Copy link
Contributor

@cherylEnkidu cherylEnkidu commented Nov 16, 2022 •
edited
Loading

Description

Implemented ArenaRef which uses as a replacement of Global Reference in order to solve problems caused by JNI Global Reference limitation.

Testing

Integration tests

Type of Change

Place an x the applicable box:

  • Bug fix. (#569)(#1193)
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@cherylEnkidu cherylEnkidu added the tests-requested: quick Trigger a quick set of integration tests. label Nov 16, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Nov 16, 2022
@github-actions
Copy link

github-actions bot commented Nov 16, 2022 •
edited
Loading

❌  Integration test FAILED

Requested by @cherylEnkidu on commit 9ea2fb7
Last updated: Wed Dec 14 13:30 PST 2022
View integration test log & download artifacts

Failures Configs
firestore [TEST] [ERROR] [Android] [All 3 os] [All 2 android_device]

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Nov 16, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Nov 16, 2022
@cherylEnkidu cherylEnkidu added tests-requested: quick Trigger a quick set of integration tests. and removed tests: failed This PR's integration tests failed. labels Nov 18, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests-requested: quick Trigger a quick set of integration tests. labels Nov 18, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Nov 18, 2022
@cherylEnkidu cherylEnkidu added tests-requested: quick Trigger a quick set of integration tests. and removed tests: failed This PR's integration tests failed. labels Nov 22, 2022
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Nov 22, 2022
@github-actions github-actions bot removed the tests-requested: quick Trigger a quick set of integration tests. label Nov 22, 2022
@cherylEnkidu cherylEnkidu added the skip-release-notes Skip release notes check label Nov 22, 2022
@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Nov 22, 2022
@cherylEnkidu cherylEnkidu added tests-requested: quick Trigger a quick set of integration tests. and removed tests: failed This PR's integration tests failed. labels Nov 22, 2022
@github-actions github-actions bot added tests: failed This PR's integration tests failed. and removed tests-requested: quick Trigger a quick set of integration tests. labels Nov 22, 2022
@cherylEnkidu cherylEnkidu self-assigned this Nov 22, 2022
@cherylEnkidu cherylEnkidu added tests-requested: quick Trigger a quick set of integration tests. and removed tests: failed This PR's integration tests failed. labels Nov 22, 2022
@github-actions github-actions bot removed the tests-requested: quick Trigger a quick set of integration tests. label Nov 22, 2022
@cherylEnkidu cherylEnkidu added tests-requested: quick Trigger a quick set of integration tests. and removed tests: failed This PR's integration tests failed. labels Dec 13, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests-requested: quick Trigger a quick set of integration tests. labels Dec 13, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Dec 13, 2022
@cherylEnkidu cherylEnkidu added tests-requested: quick Trigger a quick set of integration tests. and removed tests: failed This PR's integration tests failed. labels Dec 13, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Dec 13, 2022
@cherylEnkidu cherylEnkidu added tests-requested: quick Trigger a quick set of integration tests. and removed tests: in-progress This PR's integration tests are in progress. labels Dec 13, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests-requested: quick Trigger a quick set of integration tests. labels Dec 13, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Dec 13, 2022
@cherylEnkidu cherylEnkidu added tests-requested: quick Trigger a quick set of integration tests. and removed tests: failed This PR's integration tests failed. labels Dec 14, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests-requested: quick Trigger a quick set of integration tests. labels Dec 14, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Dec 14, 2022
@firebase firebase locked and limited conversation to collaborators Jan 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dconeybe dconeybe dconeybe requested changes

Assignees

@cherylEnkidu cherylEnkidu

Labels
skip-release-notes Skip release notes check tests: failed This PR's integration tests failed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cherylEnkidu @dconeybe