Android Auth Google I/O rework #1245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -386,7 +386,7 @@ class User : public UserInfoInterface { | |||
| /// platforms. On other platforms this method will return a Future with a | |||
There was a problem hiding this comment.
📝 Documentation issue: [10 lines up] warning: unable to resolve reference to 'LinkWithProvider(FederatedAuthProvider*)' for \ref command
| @@ -386,7 +386,7 @@ | |||
| /// platforms. On other platforms this method will return a Future with a | |||
| /// preset error code: kAuthErrorUnimplemented. | |||
| FIREBASE_DEPRECATED Future<SignInResult> LinkWithProvider_DEPRECATED( | |||
| FederatedAuthProvider* provider) const; | |||
| FederatedAuthProvider* provider); | |||
|
|
|||
| /// @deprecated This is a deprecated method. Please use @ref Unlink(const | |||
There was a problem hiding this comment.
📝 Documentation issue: warning: unable to resolve reference to 'Unlink' for \ref command
| @@ -386,7 +386,7 @@ | |||
| /// platforms. On other platforms this method will return a Future with a | |||
| /// preset error code: kAuthErrorUnimplemented. | |||
| FIREBASE_DEPRECATED Future<SignInResult> LinkWithProvider_DEPRECATED( | |||
| FederatedAuthProvider* provider) const; | |||
| FederatedAuthProvider* provider); | |||
|
|
|||
| /// @deprecated This is a deprecated method. Please use @ref Unlink(const | |||
| /// char*) instead. | |||
There was a problem hiding this comment.
📝 Documentation issue: [8 lines down] warning: unable to resolve reference to 'Unlink' for \ref command
github-actions
bot
added
the
tests: in-progress
❌ Integration test FAILEDRequested by @DellaBitta on commit 0fd6f7b
Add flaky tests to go/fpl-cpp-flake-tracker |
firebase-workflow-trigger
bot
removed
the
tests: in-progress
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes the need for User objects to be stored in AuthData, unlocking ability for there to be more than one User object at a time.
Continues to store a User in Auth, though, to maintain the implementation of the newly deprecated methods which return a User*.
Added a RetainUser integration test.
Testing
Locally tested on an iOS and Android device.
Type of Change
Place an
xthe applicable box: