Skip to content

Add support for User Messaging Platform SDK on Android #1428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 58 commits into from
Sep 14, 2023

Conversation

jonsimantov
Copy link
Contributor

@jonsimantov jonsimantov commented Aug 17, 2023

Description

Provide details of the change, and generalize the change in the PR title above.

Android implementation of UMP, mostly via a ConsentInfoHelper class.

Also adds OperationInProgress errors to iOS SDK.


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Integration tests running in this PR, plus manual testing on Android emulator.


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@jonsimantov jonsimantov changed the title Feature/ump sdk android UMP SDK on Android Aug 18, 2023
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests: failed This PR's integration tests failed. labels Sep 12, 2023
@firebase firebase deleted a comment from github-actions bot Sep 12, 2023
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Sep 12, 2023
@github-actions github-actions bot removed tests-requested: quick Trigger a quick set of integration tests. tests: failed This PR's integration tests failed. labels Sep 12, 2023
@github-actions
Copy link

github-actions bot commented Sep 12, 2023

❌  Integration test FAILED

Requested by @jonsimantov on commit 92eb594
Last updated: Thu Sep 14 14:48 PDT 2023
View integration test log & download artifacts

Failures Configs
app_check [BUILD] [ERROR] [Android] [1/3 os: windows]
firestore [TEST] [FLAKINESS] [Android] [1/3 os: macos] [1/2 android_device: android_target]
(1 failed tests)  QueryTest.TestQueriesCanUseNotEqualFiltersWithDocIds
[TEST] [FLAKINESS] [iOS] [macos] [1/2 ios_device: ios_target]
(1 failed tests)  NumericTransformsTest.IncrementDeleteIncrementInABatch

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Sep 12, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Sep 12, 2023
@jonsimantov jonsimantov marked this pull request as ready for review September 13, 2023 22:37
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests: failed This PR's integration tests failed. labels Sep 13, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Sep 13, 2023
@jonsimantov jonsimantov force-pushed the feature/ump-sdk-android branch from 8542408 to 924981b Compare September 13, 2023 23:52
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: succeeded This PR's integration tests succeeded. and removed tests: failed This PR's integration tests failed. labels Sep 13, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Sep 14, 2023
@jonsimantov jonsimantov merged commit 92eb594 into feature_branch/ump-sdk Sep 14, 2023
@jonsimantov jonsimantov deleted the feature/ump-sdk-android branch September 14, 2023 18:19
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests: succeeded This PR's integration tests succeeded. labels Sep 14, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Sep 14, 2023
@firebase firebase locked and limited conversation to collaborators Oct 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tests: failed This PR's integration tests failed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants