Skip to content

Merge main into UMP feature branch 9/21 #1454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
e0c330d
iOS: Remove Analytics dependency from GMA integration test (#1386)
jonsimantov Jul 19, 2023
3cd0dca
Add stub workflow for updating feature branches.
jonsimantov Jul 20, 2023
00eeac8
Add script to merge main into all active feature branches on a regula…
jonsimantov Jul 23, 2023
b5e5477
Increase retry. (#1402)
jonsimantov Jul 24, 2023
b9a53cf
Add Firestore test history report (#1403)
jonsimantov Jul 25, 2023
daf92c8
Revert "OR Query Implementation (#1335)" (#1399)
tom-andersen Jul 28, 2023
27a10bc
Wrap the real-time RemoteConfig test in flaky-block to automatically …
AlmostMatt Jul 31, 2023
ed42949
Merge branch 'feature_branch/ump-sdk' into main
jonsimantov Jul 31, 2023
9ac8881
Update the iOS version used by FTL (#1408)
a-maurice Jul 31, 2023
f8b6a36
Kick off nightly packaging an hour earlier (#1409)
a-maurice Aug 2, 2023
18367c0
Fix crash on gma::Initialize without a Firebase App (#1320)
AlmostMatt Aug 2, 2023
505f12e
build: pass along the CMake path (#1410)
compnerd Aug 3, 2023
5df80a2
Add log to gsutil fetch. (#1411)
jonsimantov Aug 3, 2023
3002ff4
Update mobile dependencies - Thu Aug 03 2023 (#1413)
firebase-workflow-trigger[bot] Aug 6, 2023
f198c6f
feat(auth): Add emulator support (#1400)
cynthiajoan Aug 6, 2023
f84253e
Update merge-to-main script (#1420)
jonsimantov Aug 7, 2023
64d5d42
Update release version number for M135, 11.4.0 (#1421)
AlmostMatt Aug 8, 2023
669b0fb
feat(auth): enable emulator support on desktop (#1423)
cynthiajoan Aug 10, 2023
86198bb
Internal Updates. (#1422)
nakirekommula Aug 10, 2023
7a19a44
Add Analytics function for on-device conversion (#1429)
a-maurice Aug 21, 2023
ca5cdee
Update mobile dependencies - Tue Aug 29 2023 (#1436)
firebase-workflow-trigger[bot] Aug 30, 2023
f55c43c
add UseEmulator api to auth (#1437)
cynthiajoan Aug 31, 2023
fbc3785
On Android, set dynamic code files to readonly (#1430)
jonsimantov Sep 11, 2023
0a3bd40
Update iOS dependencies - Tue Sep 12 2023 (#1443)
firebase-workflow-trigger[bot] Sep 13, 2023
697385d
Apply unused variables patch to Flatbuffers on Android as well. (#1444)
jonsimantov Sep 13, 2023
fd9a6ce
Fix iOS test version from deprecate 16.5 to 16.6. (#1449)
jonsimantov Sep 18, 2023
c5a76fa
Update Android dependencies - Mon Sep 18 2023 (#1448)
firebase-workflow-trigger[bot] Sep 18, 2023
4790c90
Add a matrix label to FTL test runs, to make sorting them easier. (#1…
jonsimantov Sep 19, 2023
8bf27f2
Merge branch 'main' into workflow/update-feature-branch-09-21
jonsimantov Sep 21, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/integration_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -1046,6 +1046,7 @@ jobs:
test_devices: ${{ steps.device-info.outputs.device }}
max_attempts: 3
validator: ${GITHUB_WORKSPACE}/scripts/gha/integration_testing/ftl_gha_validator.py
additional_flags: '--client-details matrixLabel=android-${{ github.run_id }}-${{ matrix.build_os }}-${{ matrix.android_device }}'
- name: Read FTL Test Result
if: ${{ steps.device-info.outputs.device_type == 'ftl' && !cancelled() }}
shell: bash
Expand Down Expand Up @@ -1189,6 +1190,7 @@ jobs:
test_devices: ${{ steps.device-info.outputs.device }}
max_attempts: 3
validator: ${GITHUB_WORKSPACE}/scripts/gha/integration_testing/ftl_gha_validator.py
additional_flags: '--client-details matrixLabel=ios-${{ github.run_id }}-${{ matrix.build_os }}-${{ matrix.ios_device }}'
- name: Read FTL Test Result
if: ${{ steps.device-info.outputs.device_type == 'ftl' && !cancelled() }}
shell: bash
Expand Down
2 changes: 1 addition & 1 deletion Android/firebase_dependencies.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ project.afterEvaluate {

// Add the bill-of-materials
project.dependencies {
implementation platform('com.google.firebase:firebase-bom:32.2.3')
implementation platform('com.google.firebase:firebase-bom:32.3.1')
}
for (String lib : firebaseCpp.dependencies.libSet) {
// Generate and include the proguard file
Expand Down
4 changes: 2 additions & 2 deletions analytics/integration_test/Podfile
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,12 @@ use_frameworks! :linkage => :static

target 'integration_test' do
platform :ios, '11.0'
pod 'Firebase/Analytics', '10.14.0'
pod 'Firebase/Analytics', '10.15.0'
end

target 'integration_test_tvos' do
platform :tvos, '12.0'
pod 'Firebase/Analytics', '10.14.0'
pod 'Firebase/Analytics', '10.15.0'
end

post_install do |installer|
Expand Down
2 changes: 1 addition & 1 deletion analytics/ios_headers/FIREventNames.h
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// Copyright 2023 Google LLC

// Copied from Firebase Analytics iOS SDK 10.14.0.
// Copied from Firebase Analytics iOS SDK 10.15.0.

/// @file FIREventNames.h
///
Expand Down
2 changes: 1 addition & 1 deletion analytics/ios_headers/FIRParameterNames.h
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// Copyright 2023 Google LLC

// Copied from Firebase Analytics iOS SDK 10.14.0.
// Copied from Firebase Analytics iOS SDK 10.15.0.

/// @file FIRParameterNames.h
///
Expand Down
2 changes: 1 addition & 1 deletion analytics/ios_headers/FIRUserPropertyNames.h
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// Copyright 2023 Google LLC

// Copied from Firebase Analytics iOS SDK 10.14.0.
// Copied from Firebase Analytics iOS SDK 10.15.0.

/// @file FIRUserPropertyNames.h
///
Expand Down
2 changes: 1 addition & 1 deletion app/app_resources/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ android {
}

dependencies {
implementation platform('com.google.firebase:firebase-bom:32.2.3')
implementation platform('com.google.firebase:firebase-bom:32.3.1')
implementation 'com.google.firebase:firebase-analytics'
}

Expand Down
2 changes: 1 addition & 1 deletion app/google_api_resources/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ android {
}

dependencies {
implementation platform('com.google.firebase:firebase-bom:32.2.3')
implementation platform('com.google.firebase:firebase-bom:32.3.1')
implementation 'com.google.firebase:firebase-analytics'
implementation 'com.google.android.gms:play-services-base:18.2.0'
implementation project(':app:app_resources')
Expand Down
2 changes: 1 addition & 1 deletion app/integration_test/Podfile
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ platform :ios, '11.0'
use_frameworks! :linkage => :static

target 'integration_test' do
pod 'Firebase/Analytics', '10.14.0'
pod 'Firebase/Analytics', '10.15.0'
end

post_install do |installer|
Expand Down
2 changes: 1 addition & 1 deletion app/invites_resources/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ android {
}

dependencies {
implementation platform('com.google.firebase:firebase-bom:32.2.3')
implementation platform('com.google.firebase:firebase-bom:32.3.1')
implementation 'com.google.firebase:firebase-analytics'
implementation 'com.google.firebase:firebase-dynamic-links'
implementation project(':app:app_resources')
Expand Down
26 changes: 26 additions & 0 deletions app/src/util_android.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1587,12 +1587,33 @@ const std::vector<internal::EmbeddedFile>& CacheEmbeddedFiles(
file::GetClass(), file::GetMethodId(file::kConstructorFilePath),
cache_dir, filename);
env->DeleteLocalRef(filename);
CheckAndClearJniExceptions(env);
// Below, we would have set the file read only on a previous run. Here, set
// it to writable and then delete it before creating it again.
//
// if output_file.exists() {
if (env->CallBooleanMethod(output_file, file::GetMethodId(file::kExists))) {
CheckAndClearJniExceptions(env);
// output_file.setWritable(true);
env->CallBooleanMethod(output_file, file::GetMethodId(file::kSetWritable),
JNI_TRUE);
CheckAndClearJniExceptions(env);
// output_file.delete();
env->CallBooleanMethod(output_file, file::GetMethodId(file::kDelete));
CheckAndClearJniExceptions(env);
}
jobject output_stream = env->NewObject(
file_output_stream::GetClass(),
file_output_stream::GetMethodId(file_output_stream::kConstructorFile),
output_file);
bool failed = CheckAndClearJniExceptions(env);
if (!failed) {
// Android 14 requires that we set the open dex file to readonly BEFORE
// writing code to it.
jboolean did_set_readonly = env->CallBooleanMethod(
output_file, file::GetMethodId(file::kSetReadOnly));
// If it failed, move on and try again later after closing the file.
if (CheckAndClearJniExceptions(env)) did_set_readonly = JNI_FALSE;
jobject output_array = env->NewByteArray(it->size);
env->SetByteArrayRegion(static_cast<jbyteArray>(output_array), 0,
it->size,
Expand All @@ -1605,6 +1626,11 @@ const std::vector<internal::EmbeddedFile>& CacheEmbeddedFiles(
env->CallVoidMethod(output_stream, file_output_stream::GetMethodId(
file_output_stream::kClose));
failed |= CheckAndClearJniExceptions(env);
if (!did_set_readonly) {
env->CallBooleanMethod(output_file,
file::GetMethodId(file::kSetReadOnly));
util::CheckAndClearJniExceptions(env);
}
env->DeleteLocalRef(output_array);
env->DeleteLocalRef(output_stream);
}
Expand Down
4 changes: 4 additions & 0 deletions app/src/util_android.h
Original file line number Diff line number Diff line change
Expand Up @@ -568,6 +568,10 @@ METHOD_LOOKUP_DECLARATION(intent, INTENT_METHODS);
X(ConstructorFilePath, "<init>", "(Ljava/io/File;Ljava/lang/String;)V"), \
X(GetAbsolutePath, "getAbsolutePath", "()Ljava/lang/String;"), \
X(GetPath, "getPath", "()Ljava/lang/String;"), \
X(Exists, "exists", "()Z"), \
X(Delete, "delete", "()Z"), \
X(SetReadOnly, "setReadOnly", "()Z"), \
X(SetWritable, "setWritable", "(Z)Z"), \
X(ToUri, "toURI", "()Ljava/net/URI;")
// clang-format on
METHOD_LOOKUP_DECLARATION(file, FILE_METHODS)
Expand Down
2 changes: 1 addition & 1 deletion app_check/app_check_resources/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ android {
}

dependencies {
implementation platform('com.google.firebase:firebase-bom:32.2.3')
implementation platform('com.google.firebase:firebase-bom:32.3.1')
implementation 'com.google.firebase:firebase-appcheck'
}

Expand Down
20 changes: 10 additions & 10 deletions app_check/integration_test/Podfile
Original file line number Diff line number Diff line change
Expand Up @@ -4,20 +4,20 @@ use_frameworks! :linkage => :static

target 'integration_test' do
platform :ios, '11.0'
pod 'Firebase/AppCheck', '10.14.0'
pod 'Firebase/Database', '10.14.0'
pod 'Firebase/Auth', '10.14.0'
pod 'Firebase/Storage', '10.14.0'
pod 'Firebase/Functions', '10.14.0'
pod 'Firebase/AppCheck', '10.15.0'
pod 'Firebase/Database', '10.15.0'
pod 'Firebase/Auth', '10.15.0'
pod 'Firebase/Storage', '10.15.0'
pod 'Firebase/Functions', '10.15.0'
end

target 'integration_test_tvos' do
platform :tvos, '12.0'
pod 'Firebase/AppCheck', '10.14.0'
pod 'Firebase/Database', '10.14.0'
pod 'Firebase/Auth', '10.14.0'
pod 'Firebase/Storage', '10.14.0'
pod 'Firebase/Functions', '10.14.0'
pod 'Firebase/AppCheck', '10.15.0'
pod 'Firebase/Database', '10.15.0'
pod 'Firebase/Auth', '10.15.0'
pod 'Firebase/Storage', '10.15.0'
pod 'Firebase/Functions', '10.15.0'
end

post_install do |installer|
Expand Down
2 changes: 1 addition & 1 deletion auth/auth_resources/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ android {
}

dependencies {
implementation platform('com.google.firebase:firebase-bom:32.2.3')
implementation platform('com.google.firebase:firebase-bom:32.3.1')
implementation 'com.google.firebase:firebase-analytics'
implementation 'com.google.firebase:firebase-auth'
implementation project(':app:app_resources')
Expand Down
4 changes: 2 additions & 2 deletions auth/integration_test/Podfile
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,12 @@ use_frameworks! :linkage => :static

target 'integration_test' do
platform :ios, '11.0'
pod 'Firebase/Auth', '10.14.0'
pod 'Firebase/Auth', '10.15.0'
end

target 'integration_test_tvos' do
platform :tvos, '12.0'
pod 'Firebase/Auth', '10.14.0'
pod 'Firebase/Auth', '10.15.0'
end

post_install do |installer|
Expand Down
2 changes: 1 addition & 1 deletion cmake/external/firestore.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ endif()

# If the format of the line below changes, then be sure to update
# https://github.com/firebase/firebase-cpp-sdk/blob/fd054fa016/.github/workflows/update-dependencies.yml#L81
set(version CocoaPods-10.14.0)
set(version CocoaPods-10.15.0)

function(GetReleasedDep)
message("Getting released firebase-ios-sdk @ ${version}")
Expand Down
6 changes: 3 additions & 3 deletions cpp_sdk_version.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"released": "11.4.0",
"stable": "11.4.0",
"head": "11.4.0"
"released": "11.5.0",
"stable": "11.5.0",
"head": "11.5.0"
}
2 changes: 1 addition & 1 deletion database/database_resources/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ android {
}

dependencies {
implementation platform('com.google.firebase:firebase-bom:32.2.3')
implementation platform('com.google.firebase:firebase-bom:32.3.1')
implementation 'com.google.firebase:firebase-analytics'
implementation 'com.google.firebase:firebase-database'
//implementation project(':app:app_resources')
Expand Down
8 changes: 4 additions & 4 deletions database/integration_test/Podfile
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,14 @@ use_frameworks! :linkage => :static

target 'integration_test' do
platform :ios, '11.0'
pod 'Firebase/Database', '10.14.0'
pod 'Firebase/Auth', '10.14.0'
pod 'Firebase/Database', '10.15.0'
pod 'Firebase/Auth', '10.15.0'
end

target 'integration_test_tvos' do
platform :tvos, '12.0'
pod 'Firebase/Database', '10.14.0'
pod 'Firebase/Auth', '10.14.0'
pod 'Firebase/Database', '10.15.0'
pod 'Firebase/Auth', '10.15.0'
end

post_install do |installer|
Expand Down
2 changes: 1 addition & 1 deletion dynamic_links/integration_test/Podfile
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ platform :ios, '11.0'
use_frameworks! :linkage => :static

target 'integration_test' do
pod 'Firebase/DynamicLinks', '10.14.0'
pod 'Firebase/DynamicLinks', '10.15.0'
end

post_install do |installer|
Expand Down
2 changes: 1 addition & 1 deletion firestore/firestore_resources/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ android {
}

dependencies {
implementation platform('com.google.firebase:firebase-bom:32.2.3')
implementation platform('com.google.firebase:firebase-bom:32.3.1')
implementation 'com.google.firebase:firebase-analytics'
implementation 'com.google.firebase:firebase-firestore'
}
Expand Down
8 changes: 4 additions & 4 deletions firestore/integration_test/Podfile
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,14 @@ use_frameworks! :linkage => :static

target 'integration_test' do
platform :ios, '11.0'
pod 'Firebase/Firestore', '10.14.0'
pod 'Firebase/Auth', '10.14.0'
pod 'Firebase/Firestore', '10.15.0'
pod 'Firebase/Auth', '10.15.0'
end

target 'integration_test_tvos' do
platform :tvos, '12.0'
pod 'Firebase/Firestore', '10.14.0'
pod 'Firebase/Auth', '10.14.0'
pod 'Firebase/Firestore', '10.15.0'
pod 'Firebase/Auth', '10.15.0'
end

post_install do |installer|
Expand Down
8 changes: 4 additions & 4 deletions firestore/integration_test_internal/Podfile
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,14 @@ use_frameworks! :linkage => :static

target 'integration_test' do
platform :ios, '11.0'
pod 'Firebase/Firestore', '10.14.0'
pod 'Firebase/Auth', '10.14.0'
pod 'Firebase/Firestore', '10.15.0'
pod 'Firebase/Auth', '10.15.0'
end

target 'integration_test_tvos' do
platform :tvos, '12.0'
pod 'Firebase/Firestore', '10.14.0'
pod 'Firebase/Auth', '10.14.0'
pod 'Firebase/Firestore', '10.15.0'
pod 'Firebase/Auth', '10.15.0'
end

post_install do |installer|
Expand Down
8 changes: 4 additions & 4 deletions functions/integration_test/Podfile
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,14 @@ use_frameworks! :linkage => :static

target 'integration_test' do
platform :ios, '11.0'
pod 'Firebase/Functions', '10.14.0'
pod 'Firebase/Auth', '10.14.0'
pod 'Firebase/Functions', '10.15.0'
pod 'Firebase/Auth', '10.15.0'
end

target 'integration_test_tvos' do
platform :tvos, '12.0'
pod 'Firebase/Functions', '10.14.0'
pod 'Firebase/Auth', '10.14.0'
pod 'Firebase/Functions', '10.15.0'
pod 'Firebase/Auth', '10.15.0'
end

post_install do |installer|
Expand Down
2 changes: 1 addition & 1 deletion gma/gma_resources/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ android {
}

dependencies {
implementation platform('com.google.firebase:firebase-bom:32.2.3')
implementation platform('com.google.firebase:firebase-bom:32.3.1')
implementation 'com.google.firebase:firebase-analytics'
implementation 'com.google.android.gms:play-services-ads:22.3.0'
implementation 'com.google.android.ump:user-messaging-platform:2.1.0'
Expand Down
4 changes: 2 additions & 2 deletions gma/integration_test/Podfile
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ platform :ios, '11.0'
use_frameworks! :linkage => :static

target 'integration_test' do
pod 'Firebase/CoreOnly', '10.14.0'
pod 'Google-Mobile-Ads-SDK', '10.9.0'
pod 'Firebase/CoreOnly', '10.15.0'
pod 'Google-Mobile-Ads-SDK', '10.10.0'
pod 'GoogleUserMessagingPlatform', '2.1.0'
end

Expand Down
4 changes: 2 additions & 2 deletions installations/integration_test/Podfile
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ platform :ios, '11.0'
use_frameworks! :linkage => :static

target 'integration_test' do
pod 'Firebase/Analytics', '10.14.0'
pod 'Firebase/Installations', '10.14.0'
pod 'Firebase/Analytics', '10.15.0'
pod 'Firebase/Installations', '10.15.0'
end

post_install do |installer|
Expand Down
Loading