Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Firebase Android BoM 33.3.0 while also including the Gradle 7 change. #1653

Merged
merged 25 commits into from
Sep 26, 2024

Conversation

jonsimantov
Copy link
Contributor

Description

Provide details of the change, and generalize the change in the PR title above.


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Sep 25, 2024
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Sep 25, 2024
Copy link

github-actions bot commented Sep 25, 2024

❌  Integration test FAILED

Requested by @jonsimantov on commit 1431a42
Last updated: Thu Sep 26 01:38 PDT 2024
View integration test log & download artifacts

Failures Configs
firestore
(4 items)[TEST] [ERROR] [Android] [1/3 os: ubuntu] [1/2 android_device: android_target]
[TEST] [FAILURE] [Android] [1/3 os: ubuntu] [1/2 android_device: android_target]
(1 failed tests)  SourceTest.GetCollectionWhileOnlineWithDefaultGetOptions
[TEST] [FLAKINESS] [Android] [1/3 os: windows] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT
[TEST] [FLAKINESS] [Android] [2/3 os: windows ubuntu] [1/2 android_device: emulator_ftl_target]
(1 failed tests)  CRASH/TIMEOUT
installations [TEST] [FLAKINESS] [Android] [1/3 os: windows] [All 2 android_device]
(1 failed tests)  FirebaseInstallationsTest.TestCanGetToken
messaging [TEST] [FLAKINESS] [Android] [1/3 os: ubuntu] [1/2 android_device: android_target]
(1 failed tests)  FirebaseMessagingTest.TestSendMessageToToken
[TEST] [FLAKINESS] [Android] [1/3 os: windows] [1/2 android_device: emulator_ftl_target]
(1 failed tests)  CRASH/TIMEOUT
storage [TEST] [FLAKINESS] [Android] [1/3 os: windows] [1/2 android_device: emulator_ftl_target]
(1 failed tests)  CRASH/TIMEOUT

Add flaky tests to go/fpl-cpp-flake-tracker

@jonsimantov jonsimantov changed the base branch from main to am-gradle_update September 25, 2024 23:10
@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Sep 26, 2024
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Sep 26, 2024
@jonsimantov jonsimantov marked this pull request as ready for review September 26, 2024 06:17
@jonsimantov jonsimantov changed the base branch from am-gradle_update to main September 26, 2024 06:18
@jonsimantov jonsimantov changed the title Test updating to Firebase Android BoM 33.3.0 while also including the Gradle 7 change. Update to Firebase Android BoM 33.3.0 while also including the Gradle 7 change. Sep 26, 2024
@jonsimantov jonsimantov merged commit 1431a42 into main Sep 26, 2024
29 checks passed
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests: succeeded This PR's integration tests succeeded. labels Sep 26, 2024
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Sep 26, 2024
@firebase firebase locked and limited conversation to collaborators Oct 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tests: failed This PR's integration tests failed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants