Skip to content

fix: precision timestamp detection issue #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 3, 2023
Merged

fix: precision timestamp detection issue #137

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
68bc8aa
fix for imprecise time strings
ekalosak Sep 16, 2023
5a67d62
Merge branch 'main' into fix/precision-timestamp
ekalosak Sep 21, 2023
7ff2386
Merge branch 'main' into fix/precision-timestamp
ekalosak Sep 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/firebase_functions/private/util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,7 +340,10 @@ def nanoseconds_timestamp_conversion(time: str) -> _dt.datetime:
def is_precision_timestamp(time: str) -> bool:
"""Return a bool which indicates if the timestamp is in nanoseconds"""
# Split the string into date-time and fraction of second
_, s_fraction = time.split(".")
try:
_, s_fraction = time.split(".")
except ValueError:
return False # If there's no decimal, it's not a nanosecond timestamp.

# Split the fraction from the timezone specifier ('Z' or 'z')
s_fraction, _ = s_fraction.split(
Expand Down