Cleanup config after test run #68
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I need to change the firebase functions configuration sometimes while testing and there is no clear documentation on how to do that. I've added a test case that fails when changing the functions config between test runs, and a fix to the test configuration fix the test.
However, I am not sure if that is the way it should be done. I was surprised that the cleanup function didn't do this and thought about adding this step to that. However the cleanup function doesn't have anything to do with functions config right now so I wasn't sure if that was desirable. If that is the way this should be done then I would be happy to modify this pull request to do that.
Details
firebase-functions only inits the config one time, and otherwise uses a singleton object. So just deleting the
process.env.CLOUD_RUNTIME_CONFIGduring test runs is insufficient. You must also delete thefunctions.config.singletonobject.