Remove infinite wrapping of withInit (#1540)

* Remove infinite wrapping of withInit * Changelog
firebase · Mar 19, 2024 · ad6cd43 · ad6cd43
1 parent 0aaedc4
commit ad6cd43
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -0,0 +1,2 @@
+Fix bug where 1st gen functions eventually fail with stack too deep (#1540)
+Make simple CORS options static for improved debugability (#1536)
diff --git a/src/v1/cloud-functions.ts b/src/v1/cloud-functions.ts
@@ -367,6 +367,7 @@ export function makeCloudFunction<EventData>({
   service,
   triggerResource,
 }: MakeCloudFunctionArgs<EventData>): CloudFunction<EventData> {
+  handler = withInit(handler);
   const cloudFunction: any = (data: any, context: any) => {
     if (legacyEventType && context.eventType === legacyEventType) {
       /*
@@ -404,7 +405,6 @@ export function makeCloudFunction<EventData>({
       context.params = context.params || _makeParams(context, triggerResource);
     }
 
-    handler = withInit(handler);
     let promise;
     if (labels && labels["deployment-scheduled"]) {
       // Scheduled function do not have meaningful data, so exclude it
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		Fix bug where 1st gen functions eventually fail with stack too deep (#1540)
		Make simple CORS options static for improved debugability (#1536)