Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Allow full cloud function config via FunctionBuilder API #559

Closed
joshdifabio opened this issue Sep 17, 2019 · 3 comments
Closed

[FR] Allow full cloud function config via FunctionBuilder API #559

joshdifabio opened this issue Sep 17, 2019 · 3 comments

Comments

@joshdifabio
Copy link

Is your feature request related to a problem? Please describe.
When deploying firebase functions to new projects, I have to manually edit the functions via the GCP web console in order to set timeouts, enable retries, etc., for different functions. It's easy to make a mistake when doing this and, after deploying functions for the first time, there is a period during which they are live with the wrong config (i.e. the wrong timeout or retry config) because I can't configure the functions in the GCP UI until the deployment is complete.

Describe the solution you'd like
I would like to be able to set function timeouts, enable retries (failurePolicy), etc., via the firebase-functions FunctionBuilder API, in the same way I can set the region.

Describe alternatives you've considered
I've looked at updating my functions via a bash script and the gcloud command line tool, but this really belongs with the rest of the non-environment-specific functions config (e.g. regions) in my source code.

Edit: It's actually possible to set function timeouts via FunctionBuilder.runWith(), so this issue only applies to retries (failurePolicy).

@google-oss-bot
Copy link
Collaborator

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.

@hiranya911 hiranya911 transferred this issue from firebase/firebase-admin-node Sep 17, 2019
@google-oss-bot

This comment has been minimized.

@samtstern
Copy link
Contributor

@joshdifabio sorry for the really delayed response here but the FR to implement retry policies is a duplicate of #425

The good news is that #482 implements the solution for this and we do plan to release this once we can get the necessary changes in the Firebase CLI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants