-
Notifications
You must be signed in to change notification settings - Fork 218
Firebase Functions v8 #1749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Firebase Functions v8 #1749
Conversation
taeold
commented
Oct 21, 2025
- BREAKING: Upgrade TypeScript to v5.9.3 #1746
- BREAKING: Drop Node.js 14/16 support, require Node.js >=18 #1747
Upgrades from TypeScript v4.3.5 to v5.9.3. All tests pass successfully.
* BREAKING: Drop Node.js 14/16 support, require Node.js >=18 - Update package.json engines to require Node.js >=18.0.0 - Upgrade @types/node from v14 to v18 - Update TypeScript target from ES2019 to ES2022 - Add useDefineForClassFields: false for backward compatibility - Update CI/CD workflows to test Node.js 18, 20, 22, and 24 - Set default CI/CD Node.js version to 24 - Update integration test documentation
Summary of ChangesHello @taeold, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a significant upgrade of the project's development environment by bumping the minimum Node.js version to 18 and updating TypeScript to version 5. These changes ensure the project leverages modern runtime features and type-checking capabilities, improving maintainability and compatibility with contemporary JavaScript ecosystems. The update also includes adjustments to the TypeScript compiler configuration to align with these newer versions. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates dependencies and configurations to support Node.js v18 and TypeScript v5.9.3. The changes include updates to package.json, package-lock.json, and tsconfig.release.json to reflect the new versions and configurations. I have identified a critical issue related to error handling in the firebase-functions.ts file.
Replace functions.config() implementation with an error that provides clear migration guidance to the params module. This removes the deprecated API as planned for the next major release while helping developers migrate. The error message directs users to: https://firebase.google.com/docs/functions/config-env#migrate-config
| @@ -1,3 +1,3 @@ | |||
| { | |||
| "name": "firebase-functions", | |||
| "version": "6.6.0", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
time to update version here too? (and in package-lock.json?)