Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analytics.setUserProperty nil doesn't remove it #3230

Closed
victor-sarda opened this issue Jun 20, 2019 · 7 comments
Closed

Analytics.setUserProperty nil doesn't remove it #3230

victor-sarda opened this issue Jun 20, 2019 · 7 comments

Comments

@victor-sarda
Copy link

Describe your environment

  • Xcode version: 10.2.1
  • Firebase SDK version: 6.3.0
  • Firebase Component: Analytics
  • Component version: 6.3.0

Describe the problem

When setting a user property value to nil with Analytics.setUserProperty I'm expecting it to be removed on Firebase as the documentation says:

The value of the user property. Values can be up to 36 characters long. Setting the value to nil removes the user property.

Steps to reproduce:

  1. Send a user property on firebase analytics like this
    Analytics.setUserProperty(<property>, forName: <name>).
  2. Go to the debug view in the firebase console and check that property is set
  3. Call Analytics.setUserProperty(nil, forName: <name>)
  4. Go back to the debug view

The property is still here in the debug view but I'm expecting it to be gone. This is quite annoying since we can only set 25 properties but we can't remove any.

@google-oss-bot

This comment has been minimized.

@morganchen12
Copy link
Contributor

@htcgh can you confirm this is a bug?

@allenktv
Copy link
Contributor

Thanks @victor-sarda. I just reproduced this and believe that it may just be a UI issue since the bundle uploaded does not have the user property anymore after setting it to nil.

Tracked internally at b/135926151

@victor-sarda
Copy link
Author

Thanks @allenktv 😊
Just to clarify, if we set nil right now, property is actually removed and we can set a new one instead? I guess UI should be working fine in BigQuery?

@allenktv
Copy link
Contributor

@victor-sarda
Yes I believe so.
The debug view is still an issue and we will get that fixed. Thank you for reporting this and please let us know if you encounter any more issues!

@victor-sarda
Copy link
Author

Thanks :)

@allenktv
Copy link
Contributor

allenktv commented Aug 7, 2019

Closing this issue

@allenktv allenktv closed this as completed Aug 7, 2019
@firebase firebase locked and limited conversation to collaborators Oct 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants