Use ByteString instead of std::vector in the BloomFilter #11038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
milaGGL
reviewed
Mar 30, 2023
| const std::vector<uint8_t>& bitmap1 = lhs.bitmap(); | ||
| const std::vector<uint8_t>& bitmap2 = rhs.bitmap(); | ||
| const auto byte_count = static_cast<int32_t>(bitmap1.size()); | ||
| const auto byte_count = static_cast<int32_t>(lhs.bitmap().size()); |
There was a problem hiding this comment.
I think i asked the same question before, but why auto? since we know its type will be int32_t
There was a problem hiding this comment.
Lint suggests (requires?) using auto when the type is explicitly mentioned on the right-hand side of the equal sign. By mentioning it twice it actually opens up the opportunity for an unintended implicit narrowing conversion if there is a typo on one side of the equal sign.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.