Skip to content

Firestore Spec Tests: Port JS PR 7229 (optimized query resumption using bloom filter) #11185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 26, 2023

Conversation

dconeybe
Copy link
Contributor

@dconeybe dconeybe commented Apr 26, 2023

Port spec test changes from firebase/firebase-js-sdk#7229 (Optimize local cache sync when resuming a query that had docs deleted).

Note that the integer value of QueryPurpose::LimboResolution changed from 2 to 3 in the spec test JSON files as a result of this port and, therefore, some custom logic was added into FSTSpecTests.mm to handle this correctly.

For reference, here is the Android port of the same change: firebase/firebase-android-sdk#4929

#no-changelog

Base automatically changed from dconeybe/SpecTestPortJsSdkPr7021 to master April 26, 2023 18:22
@dconeybe dconeybe merged commit 36ac6fe into master Apr 26, 2023
@dconeybe dconeybe deleted the dconeybe/SpecTestPortJsSdkPr7229 branch April 26, 2023 18:30
@google-oss-bot
Copy link

Coverage Report 1

Affected Products

  • FirebaseFirestore-iOS-FirebaseFirestore.framework

    Overall coverage changed from 88.02% (82f2534) to 88.05% (e2d81f1) by +0.03%.

    FilenameBase (82f2534)Merge (e2d81f1)Diff
    exception.cc23.68%84.21%+60.53%
    leveldb_key.cc98.82%98.33%-0.49%
    leveldb_mutation_queue.cc93.56%92.42%-1.14%
    ordered_code.cc94.39%93.90%-0.49%
    serializer.cc91.41%91.10%-0.31%
    watch_stream.cc95.35%90.70%-4.65%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/MkUP6Rsr0e.html

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants