Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the integration test to verify that bloom filter averted full requery #11440

Merged
merged 7 commits into from
Jun 19, 2023

Conversation

dconeybe
Copy link
Contributor

Update the integration test for the bloom filter to also verify that Watch specified a bloom filter that could be used to avert the full requery.

Googlers see b/274140502 for more details.

This PR is a port of firebase/firebase-js-sdk#7095, and its follow-up improvements in firebase/firebase-js-sdk#7112. The corresponding Android port is firebase/firebase-android-sdk#4768.

#no-changelog

@dconeybe dconeybe self-assigned this Jun 14, 2023
Copy link
Contributor

@milaGGL milaGGL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dconeybe dconeybe merged commit d73d97c into mila/BloomFilter Jun 19, 2023
@dconeybe dconeybe deleted the dconeybe/BloomFilterComplexIntegrationTest branch June 19, 2023 14:56
@firebase firebase locked and limited conversation to collaborators Jul 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants