Remove App Check Core Interop SDK #11595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulb777
approved these changes
Jul 24, 2023
|
|
||
| NS_ASSUME_NONNULL_BEGIN | ||
|
|
||
| NS_SWIFT_NAME(AppCheckCoreTokenHandler) |
There was a problem hiding this comment.
typedefs should be unavailable for Swift like - https://github.com/firebase/firebase-ios-sdk/blob/master/FirebaseAuth/Sources/Public/FirebaseAuth/FIRAuth.h#L38 and should be avoided in public headers for ObjC if reasonable since they'll add tech debt to the API surface when we convert to Swift.
There was a problem hiding this comment.
Thanks for the heads up on the Swift interop! I think this one was reasonable to remove from the header.
Removed the GACAppCheckTokenHandler typedef from GACAppCheck.h.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ObjC Protocol-only interop SDK is not needed by our integrators.
#no-changelog