Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FPRDataUtils.m #13200

Merged
merged 1 commit into from
Jun 28, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Update FPRDataUtils.m
Add NSNotFound check to protect crash
Kyle-Ye authored Jun 28, 2024

Verified

This commit was signed with the committer’s verified signature.
timryanb Tim Brooks
commit 2fa0a7ac2be2266155503676e7880e4dec977c38
5 changes: 3 additions & 2 deletions FirebasePerformance/Sources/FPRDataUtils.m
Original file line number Diff line number Diff line change
@@ -116,9 +116,10 @@
if (![pathSeparator isEqual:truncationCharacter]) {
NSRange rangeOfTruncation = [truncatedURLString rangeOfString:pathSeparator
options:NSBackwardsSearch];
truncatedURLString = [URLString substringToIndex:rangeOfTruncation.location];
if (rangeOfTruncation.location != NSNotFound) {
truncatedURLString = [URLString substringToIndex:rangeOfTruncation.location];
visumickey marked this conversation as resolved.
Show resolved Hide resolved
}
}

FPRLogWarning(kFPRClientNameTruncated, @"URL exceeds %d characters. Truncated url: %@",
kFPRMaxURLLength, truncatedURLString);
}