Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review FirebaseMessaging Tests files #13402

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ - (void)testModifyNotificationWithValidPayloadData {
[_mockExtensionHelper populateNotificationContent:content withContentHandler:handler];
OCMVerify([_mockExtensionHelper loadAttachmentForURL:[OCMArg any]
completionHandler:[OCMArg any]]);
// Wait longer to accomodate increased network latency when running on CI.
// Wait longer to accommodate increased network latency when running on CI.
[self waitForExpectationsWithTimeout:5.0 handler:nil];
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ - (void)testBatchSizeReductionAfterSuccessfulTopicUpdate {
pendingTopics.delegate = self.alwaysReadyDelegate;

XCTestExpectation *batchSizeReductionExpectation =
[self expectationWithDescription:@"Batch size was reduced after topic suscription"];
[self expectationWithDescription:@"Batch size was reduced after topic subscription"];

__weak id weakSelf = self;
self.alwaysReadyDelegate.subscriptionHandler =
Expand Down
2 changes: 1 addition & 1 deletion FirebaseMessaging/Tests/UnitTests/FIRMessagingPubSubTest.m
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ - (void)testTopicHasValidToicsPrefix {
XCTAssertTrue([FIRMessagingPubSub hasTopicsPrefix:@"/topics/"]);
}

/// Tests topic prefix wih no prefix.
/// Tests topic prefix with no prefix.
- (void)testAddTopicPrefix_withNoPrefix {
NSString *topic = [FIRMessagingPubSub addPrefixToTopic:@""];
XCTAssertTrue([FIRMessagingPubSub hasTopicsPrefix:topic]);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ - (void)application:(GULApplication *)application

@end

#pragma mark - Incompete UNUserNotificationCenterDelegate
#pragma mark - Incomplete UNUserNotificationCenterDelegate
@interface IncompleteUserNotificationCenterDelegate : NSObject <UNUserNotificationCenterDelegate>
@end
@implementation IncompleteUserNotificationCenterDelegate
Expand Down
Loading