Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vertex AI] Remove CountTokensError enum #13736

Merged
merged 3 commits into from
Sep 27, 2024
Merged

[Vertex AI] Remove CountTokensError enum #13736

merged 3 commits into from
Sep 27, 2024

Conversation

andrewheard
Copy link
Contributor

Removed the CountTokensError enum. Errors are now reported directly instead of being wrapped in CountTokensError.internalError.

#no-changelog

@andrewheard andrewheard added this to the 11.4.0 - M155 milestone Sep 27, 2024
@andrewheard andrewheard marked this pull request as ready for review September 27, 2024 20:47
@andrewheard
Merge remote-tracking branch 'origin/vertexai-release' into ah/vertex…
66ee340 
…-count-tokens-error

# Conflicts:
#	FirebaseVertexAI/CHANGELOG.md
@andrewheard andrewheard merged commit 78c341f into vertexai-release Sep 27, 2024
37 checks passed
@andrewheard andrewheard deleted the ah/vertex-count-tokens-error branch September 27, 2024 22:09
@github-actions github-actions bot mentioned this pull request Oct 22, 2024
Merged
@firebase firebase locked and limited conversation to collaborators Oct 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 approved these changes

Assignees
No one assigned
Labels
api: vertexai
Projects
None yet
Milestone
11.4.0 - M155
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewheard @paulb777 @google-oss-bot