[Vertex AI] Replace ModelContent.Part enum with protocol/structs
#13767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
andrewheard
force-pushed
the
ah/vertex-part-struct
branch
from
ec2001f to
afda484
Compare
# Conflicts: # FirebaseVertexAI/Sources/GenerativeModel.swift
andrewheard
force-pushed
the
ah/vertex-part-struct
branch
from
011b13d to
ba223a9
Compare
paulb777
approved these changes
Oct 7, 2024
FirebaseVertexAI/Sample/FunctionCallingSample/ViewModels/FunctionCallingViewModel.swift
Outdated
Show resolved
Hide resolved
MojtabaHs
pushed a commit
to MojtabaHs/firebase-ios-sdk
that referenced
this pull request
Oct 17, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced the
ModelContent.Partenum with a protocol namedPart. Sinceswitchstatements over enums in Swift need to be exhaustive, this has been done to avoid future breaking changes as new types of parts are added for input to, or output from, the model.The existing enum cases have been replaced with the following types:
TextPartInlineDataPartFileDataPartFunctionCallPartFunctionResponsePartNote: TODOs and additional documentation will be addressed in follow-up PRs since they don't impact the public API.