Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Performance Unit Test Warnings around UserDefaults #13787

Merged
merged 3 commits into from
Oct 3, 2024
Merged

Fix Performance Unit Test Warnings around UserDefaults #13787

merged 3 commits into from
Oct 3, 2024

Conversation

samedson
Copy link
Contributor

@samedson samedson commented Oct 3, 2024 •
edited
Loading

These were causing warnings in unit tests

#no-changelog

@firebase firebase deleted a comment from google-oss-bot Oct 3, 2024
visumickey
visumickey approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@visumickey visumickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since all of these tests are just on unit tests, the code looks good to me. The same change cannot be easily made on the SDK since there are configs that retain the value in user defaults.

@samedson samedson merged commit ba8623f into main Oct 3, 2024
41 checks passed
@samedson samedson deleted the userdefaults-gul branch October 3, 2024 19:42
@github-actions github-actions bot mentioned this pull request Oct 22, 2024
Merged
@firebase firebase locked and limited conversation to collaborators Nov 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@themiswang themiswang themiswang approved these changes

@visumickey visumickey visumickey approved these changes

Assignees
No one assigned
Labels
api: performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@samedson @visumickey @themiswang @google-oss-bot