Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a property name in FirebaseInAppMessaging #13788

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Fix a property name in FirebaseInAppMessaging #13788

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions FirebaseInAppMessaging/Sources/Flows/FIRIAMMessageClientCache.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,15 +108,15 @@ - (void)setupAnalyticsEventListening {
}
}

if (self.analycisEventDislayCheckFlow) {
if (self.analyticsEventDisplayCheckFlow) {
if ([self.firebaseAnalyticEventsToWatch count] > 0) {
FIRLogDebug(kFIRLoggerInAppMessaging, @"I-IAM160010",
@"There are analytics event trigger based messages, enable listening");
[self.analycisEventDislayCheckFlow start];
[self.analyticsEventDisplayCheckFlow start];
} else {
FIRLogDebug(kFIRLoggerInAppMessaging, @"I-IAM160011",
@"No analytics event trigger based messages, disable listening");
[self.analycisEventDislayCheckFlow stop];
[self.analyticsEventDisplayCheckFlow stop];
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion FirebaseInAppMessaging/Sources/Private/Flows/FIRIAMMessageClientCache.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ API_AVAILABLE(ios(13.0), tvos(13.0))
// analytics event listening based on the latest message definitions
// make it weak to avoid retaining cycle
@property(nonatomic, weak, nullable)
FIRIAMDisplayCheckOnAnalyticEventsFlow *analycisEventDislayCheckFlow;
FIRIAMDisplayCheckOnAnalyticEventsFlow *analyticsEventDisplayCheckFlow;

- (instancetype)init NS_UNAVAILABLE;
- (instancetype)initWithBookkeeper:(id<FIRIAMBookKeeper>)bookKeeper
Expand Down
2 changes: 1 addition & 1 deletion FirebaseInAppMessaging/Sources/Runtime/FIRIAMRuntimeManager.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,7 @@ - (void)internalStartRuntimeWithSDKSettings:(FIRIAMSDKSettings *)settings {
self.displayOnFIRAnalyticEventsFlow =
[[FIRIAMDisplayCheckOnAnalyticEventsFlow alloc] initWithDisplayFlow:self.displayExecutor];

self.messageCache.analycisEventDislayCheckFlow = self.displayOnFIRAnalyticEventsFlow;
self.messageCache.analyticsEventDisplayCheckFlow = self.displayOnFIRAnalyticEventsFlow;
[self.messageCache
loadMessageDataFromServerFetchStorage:self.fetchResultStorage
withCompletion:^(BOOL success) {
Expand Down
6 changes: 3 additions & 3 deletions FirebaseInAppMessaging/Tests/Unit/FIRIAMMessageClientCacheTests.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,7 +325,7 @@ - (void)testCallingStartAnalyticsEventListenFlow_ok {

FIRIAMDisplayCheckOnAnalyticEventsFlow *mockAnalyticsEventFlow =
OCMClassMock(FIRIAMDisplayCheckOnAnalyticEventsFlow.class);
self.clientCache.analycisEventDislayCheckFlow = mockAnalyticsEventFlow;
self.clientCache.analyticsEventDisplayCheckFlow = mockAnalyticsEventFlow;

// m2 and m4 are messages rendered on 'test_event' Firebase Analytics event
// so we espect the analytics event listening flow to be started
Expand All @@ -339,7 +339,7 @@ - (void)testCallingStopAnalyticsEventListenFlow_ok {

FIRIAMDisplayCheckOnAnalyticEventsFlow *mockAnalyticsEventFlow =
OCMClassMock(FIRIAMDisplayCheckOnAnalyticEventsFlow.class);
self.clientCache.analycisEventDislayCheckFlow = mockAnalyticsEventFlow;
self.clientCache.analyticsEventDisplayCheckFlow = mockAnalyticsEventFlow;

// m1 and m3 are messages rendered on app foreground triggers
OCMExpect([mockAnalyticsEventFlow stop]);
Expand All @@ -352,7 +352,7 @@ - (void)testCallingStartAndThenStopAnalyticsEventListenFlow_ok {

FIRIAMDisplayCheckOnAnalyticEventsFlow *mockAnalyticsEventFlow =
OCMClassMock(FIRIAMDisplayCheckOnAnalyticEventsFlow.class);
self.clientCache.analycisEventDislayCheckFlow = mockAnalyticsEventFlow;
self.clientCache.analyticsEventDisplayCheckFlow = mockAnalyticsEventFlow;

// start is triggered on the setMessageData: call
OCMExpect([mockAnalyticsEventFlow start]);
Expand Down
Loading