Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated podspec for internal FirebaseCore header #13829

Merged
merged 3 commits into from
Oct 7, 2024
Merged

Conversation

paulb777
Copy link
Member

@paulb777 paulb777 commented Oct 5, 2024

Fix #13824

@paulb777 paulb777 mentioned this pull request Oct 5, 2024
@paulb777 paulb777 marked this pull request as draft October 5, 2024 16:35
@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@paulb777 paulb777 marked this pull request as ready for review October 7, 2024 17:59
@paulb777
Copy link
Member Author

paulb777 commented Oct 7, 2024

Looking promising now.

I'm getting convinced in the longer term, we should make a clean FirebaseExtensions module with all the "Internal" APIs and implementations for other Firebase modules.

@paulb777
Copy link
Member Author

paulb777 commented Oct 7, 2024

Updating CocoaPods-11.4.0 to this PR fixed all relevant nightlies except release and prerelease - which need nightly tag updated also. zip is still running, but well past the nightly failure.

@paulb777 paulb777 requested a review from ncooke3 October 7, 2024 20:04
@paulb777 paulb777 merged commit 14b94aa into main Oct 7, 2024
62 checks passed
@paulb777 paulb777 deleted the pb-podspec-fix branch October 7, 2024 20:37
MojtabaHs pushed a commit to MojtabaHs/firebase-ios-sdk that referenced this pull request Oct 17, 2024
@firebase firebase locked and limited conversation to collaborators Nov 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nightly Testing Report
3 participants