Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vertex AI] Remove from zip build #13871

Merged
merged 1 commit into from
Oct 11, 2024
Merged

[Vertex AI] Remove from zip build #13871

merged 1 commit into from
Oct 11, 2024

Conversation

andrewheard
Copy link
Contributor

@andrewheard andrewheard commented Oct 10, 2024 •
edited
Loading

  • Removed the Vertex AI SDK from the zip build (zip: false).
  • Re-ordered the FirebaseVertexAI pod to come after the Firebase pod to ensure it is not a dependency.
  • Set releasing: false so it is not printed in the list when calling swift run --package-path ReleaseTooling firebase-releaser --publish true --log-only true --git-root <release_dir>
    • The pod could be manually pushed by running pod trunk push --skip-tests --synchronous ~/.cocoapods/repos/spec-staging/FirebaseVertexAI/11.4.0/FirebaseVertexAI.podspec.json if the timing works out.

#no-changelog

@andrewheard andrewheard added this to the 11.4.0 - M155 milestone Oct 10, 2024
paulb777
paulb777 approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @andrewheard

ncooke3
ncooke3 approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@ncooke3 ncooke3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great writeup!

@andrewheard andrewheard marked this pull request as ready for review October 11, 2024 00:16
@andrewheard andrewheard merged commit 4e50fd8 into main Oct 11, 2024
65 checks passed
@andrewheard andrewheard deleted the ah/vertex-remove-from-zip branch October 11, 2024 00:17
MojtabaHs pushed a commit to MojtabaHs/firebase-ios-sdk that referenced this pull request Oct 17, 2024
@andrewheard @MojtabaHs
[Vertex AI] Remove from zip build (firebase#13871)
2791bbd
@github-actions github-actions bot mentioned this pull request Oct 22, 2024
Merged
@firebase firebase locked and limited conversation to collaborators Nov 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ncooke3 ncooke3 ncooke3 approved these changes

@paulb777 paulb777 paulb777 approved these changes

Assignees
No one assigned
Labels
api: vertexai release-tooling
Projects
None yet
Milestone
11.4.0 - M155
Development

Successfully merging this pull request may close these issues.
4 participants
@andrewheard @paulb777 @ncooke3 @google-oss-bot