Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Python version from 3.7 to 3.11 in GitHub Actions workflows #14301

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

dconeybe
Copy link
Contributor

@dconeybe dconeybe commented Jan 3, 2025

Fix the following error from the setup-python steps by upgrading Python from 3.7 to 3.11, which is what all of the other setup-python steps use:

Version 3.7 was not found in the local cache
##[error]The version '3.7' with architecture 'x64' was not found for Ubuntu 24.04.
The list of all available versions can be found here: https://raw.githubusercontent.com/actions/python-versions/main/versions-manifest.json

#no-changelog

@dconeybe dconeybe self-assigned this Jan 3, 2025
@dconeybe
Copy link
Contributor Author

dconeybe commented Jan 3, 2025

The sanitizers-ubuntu failure needs to be investigated, but shouldn't block merging this PR as the PR does its job of fixing the action from running altogether.

Here are the two failures from sanitzers-ubuntu https://github.com/firebase/firebase-ios-sdk/actions/runs/12593759439/job/35100280549?pr=14301:

Failure 1: firestore_remote_test

[ RUN      ] StreamTest.ObserverReceivesStreamCloseOnError
=================================================================
==22279==ERROR: AddressSanitizer: stack-use-after-return on address 0x7f3c4d7589d0 at pc 0x7f3c5507d96f bp 0x7f3c515febd0 sp 0x7f3c515fe378
READ of size 13 at 0x7f3c4d7589d0 thread T509
    #0 0x7f3c5507d96e in strlen ../../../../src/libsanitizer/sanitizer_common/sanitizer_common_interceptors.inc:391
    #1 0x55e2f38c80dd in absl::lts_20240116::string_view::StrlenInternal(char const*) /home/runner/work/firebase-ios-sdk/firebase-ios-sdk/build/external/src/abseil-cpp/absl/strings/string_view.h:684
    #2 0x55e2f38c8012 in absl::lts_20240116::string_view::string_view(char const*) /home/runner/work/firebase-ios-sdk/firebase-ios-sdk/build/external/src/abseil-cpp/absl/strings/string_view.h:200
    #3 0x55e2f3fda851 in operator() /home/runner/work/firebase-ios-sdk/firebase-ios-sdk/Firestore/core/src/util/string_format.cc:61
    #4 0x55e2f3fdab6a in operator() /home/runner/work/firebase-ios-sdk/firebase-ios-sdk/Firestore/core/src/util/string_format.cc:80
    #5 0x55e2f3fdad07 in firebase::firestore::util::internal::StringFormatPieces[abi:cxx11](char const*, std::initializer_list<absl::lts_20240116::string_view>) /home/runner/work/firebase-ios-sdk/firebase-ios-sdk/Firestore/core/src/util/string_format.cc:109
    #6 0x55e2f3e0f4ec in std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > firebase::firestore::util::StringFormat<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, firebase::firestore::remote::Stream const*>(char const*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, firebase::firestore::remote::Stream const* const&) /home/runner/work/firebase-ios-sdk/firebase-ios-sdk/Firestore/core/src/util/string_format.h:161
    #7 0x55e2f3e0bfcd in firebase::firestore::remote::Stream::GetDebugDescription[abi:cxx11]() const /home/runner/work/firebase-ios-sdk/firebase-ios-sdk/Firestore/core/src/remote/stream.cc:383
    #8 0x55e2f3e0b575 in firebase::firestore::remote::Stream::OnStreamFinish(firebase::firestore::util::Status const&) /home/runner/work/firebase-ios-sdk/firebase-ios-sdk/Firestore/core/src/remote/stream.cc:357
    #9 0x55e2f3d8be9a in firebase::firestore::remote::GrpcStream::FinishAndNotify(firebase::firestore::util::Status const&) /home/runner/work/firebase-ios-sdk/firebase-ios-sdk/Firestore/core/src/remote/grpc_stream.cc:179
    #10 0x55e2f3d8da06 in operator() /home/runner/work/firebase-ios-sdk/firebase-ios-sdk/Firestore/core/src/remote/grpc_stream.cc:321
    #11 0x55e2f3d8fc82 in __invoke_impl<void, firebase::firestore::remote::GrpcStream::OnOperationFailed()::<lambda(const std::shared_ptr<firebase::firestore::remote::GrpcCompletion>&)>&, const std::shared_ptr<firebase::firestore::remote::GrpcCompletion>&> /usr/include/c++/13/bits/invoke.h:61
    #12 0x55e2f3d8f6ae in __invoke_r<void, firebase::firestore::remote::GrpcStream::OnOperationFailed()::<lambda(const std::shared_ptr<firebase::firestore::remote::GrpcCompletion>&)>&, const std::shared_ptr<firebase::firestore::remote::GrpcCompletion>&> /usr/include/c++/13/bits/invoke.h:150
    #13 0x55e2f3d8ef91 in _M_invoke /usr/include/c++/13/bits/std_function.h:290
    #14 0x55e2f3d92918 in std::function<void (std::shared_ptr<firebase::firestore::remote::GrpcCompletion> const&)>::operator()(std::shared_ptr<firebase::firestore::remote::GrpcCompletion> const&) const (/home/runner/work/firebase-ios-sdk/firebase-ios-sdk/build/Firestore/core/test/unit/remote/firestore_remote_test+0xd86918) (BuildId: f7c12f95667149168e8d09e2d8dce95145d40cca)
    #15 0x55e2f3d8e15a in operator() /home/runner/work/firebase-ios-sdk/firebase-ios-sdk/Firestore/core/src/remote/grpc_stream.cc:342
    #16 0x55e2f3d8fd88 in __invoke_impl<void, firebase::firestore::remote::GrpcStream::NewCompletion(firebase::firestore::remote::Type, const OnSuccess&)::<lambda(bool, const std::shared_ptr<firebase::firestore::remote::GrpcCompletion>&)>&, bool, const std::shared_ptr<firebase::firestore::remote::GrpcCompletion>&> /usr/include/c++/13/bits/invoke.h:61
    #17 0x55e2f3d8f977 in __invoke_r<void, firebase::firestore::remote::GrpcStream::NewCompletion(firebase::firestore::remote::Type, const OnSuccess&)::<lambda(bool, const std::shared_ptr<firebase::firestore::remote::GrpcCompletion>&)>&, bool, const std::shared_ptr<firebase::firestore::remote::GrpcCompletion>&> /usr/include/c++/13/bits/invoke.h:150
    #18 0x55e2f3d8f0f8 in _M_invoke /usr/include/c++/13/bits/std_function.h:290
    #19 0x55e2f3d5675f in std::function<void (bool, std::shared_ptr<firebase::firestore::remote::GrpcCompletion> const&)>::operator()(bool, std::shared_ptr<firebase::firestore::remote::GrpcCompletion> const&) const /usr/include/c++/13/bits/std_function.h:591
    #20 0x55e2f3d550dd in operator() /home/runner/work/firebase-ios-sdk/firebase-ios-sdk/Firestore/core/src/remote/grpc_completion.cc:95
    #21 0x55e2f3d5599f in __invoke_impl<void, firebase::firestore::remote::GrpcCompletion::Complete(bool)::<lambda()>&> /usr/include/c++/13/bits/invoke.h:61
    #22 0x55e2f3d5583f in __invoke_r<void, firebase::firestore::remote::GrpcCompletion::Complete(bool)::<lambda()>&> /usr/include/c++/13/bits/invoke.h:150
    #23 0x55e2f3d55618 in _M_invoke /usr/include/c++/13/bits/std_function.h:290
    #24 0x55e2f39a511b in std::function<void ()>::operator()() const /usr/include/c++/13/bits/std_function.h:591
    #25 0x55e2f3fc0365 in firebase::firestore::util::AsyncQueue::ExecuteBlocking(std::function<void ()> const&) /home/runner/work/firebase-ios-sdk/firebase-ios-sdk/Firestore/core/src/util/async_queue.cc:89
    #26 0x55e2f3fc114c in operator() /home/runner/work/firebase-ios-sdk/firebase-ios-sdk/Firestore/core/src/util/async_queue.cc:144
    #27 0x55e2f3fc2f09 in __invoke_impl<void, firebase::firestore::util::AsyncQueue::Wrap(const Operation&)::<lambda()>&> /usr/include/c++/13/bits/invoke.h:61
    #28 0x55e2f3fc2bb8 in __invoke_r<void, firebase::firestore::util::AsyncQueue::Wrap(const Operation&)::<lambda()>&> /usr/include/c++/13/bits/invoke.h:150
    #29 0x55e2f3fc2843 in _M_invoke /usr/include/c++/13/bits/std_function.h:290
    #30 0x55e2f39a511b in std::function<void ()>::operator()() const /usr/include/c++/13/bits/std_function.h:591
    #31 0x55e2f3fdc98b in firebase::firestore::util::Task::ExecuteAndRelease() /home/runner/work/firebase-ios-sdk/firebase-ios-sdk/Firestore/core/src/util/task.cc:102
    #32 0x55e2f3fea904 in firebase::firestore::util::ExecutorStd::PollingThread(std::shared_ptr<firebase::firestore::util::ExecutorStd::SharedState>) /home/runner/work/firebase-ios-sdk/firebase-ios-sdk/Firestore/core/src/util/executor_std.cc:180
    #33 0x55e2f3ff6cf4 in void std::__invoke_impl<void, void (*)(std::shared_ptr<firebase::firestore::util::ExecutorStd::SharedState>), std::shared_ptr<firebase::firestore::util::ExecutorStd::SharedState> >(std::__invoke_other, void (*&&)(std::shared_ptr<firebase::firestore::util::ExecutorStd::SharedState>), std::shared_ptr<firebase::firestore::util::ExecutorStd::SharedState>&&) /usr/include/c++/13/bits/invoke.h:61
    #34 0x55e2f3ff6ba8 in std::__invoke_result<void (*)(std::shared_ptr<firebase::firestore::util::ExecutorStd::SharedState>), std::shared_ptr<firebase::firestore::util::ExecutorStd::SharedState> >::type std::__invoke<void (*)(std::shared_ptr<firebase::firestore::util::ExecutorStd::SharedState>), std::shared_ptr<firebase::firestore::util::ExecutorStd::SharedState> >(void (*&&)(std::shared_ptr<firebase::firestore::util::ExecutorStd::SharedState>), std::shared_ptr<firebase::firestore::util::ExecutorStd::SharedState>&&) /usr/include/c++/13/bits/invoke.h:96
    #35 0x55e2f3ff6aca in void std::thread::_Invoker<std::tuple<void (*)(std::shared_ptr<firebase::firestore::util::ExecutorStd::SharedState>), std::shared_ptr<firebase::firestore::util::ExecutorStd::SharedState> > >::_M_invoke<0ul, 1ul>(std::_Index_tuple<0ul, 1ul>) /usr/include/c++/13/bits/std_thread.h:292
    #36 0x55e2f3ff6a61 in std::thread::_Invoker<std::tuple<void (*)(std::shared_ptr<firebase::firestore::util::ExecutorStd::SharedState>), std::shared_ptr<firebase::firestore::util::ExecutorStd::SharedState> > >::operator()() /usr/include/c++/13/bits/std_thread.h:299
    #37 0x55e2f3ff6795 in std::thread::_State_impl<std::thread::_Invoker<std::tuple<void (*)(std::shared_ptr<firebase::firestore::util::ExecutorStd::SharedState>), std::shared_ptr<firebase::firestore::util::ExecutorStd::SharedState> > > >::_M_run() /usr/include/c++/13/bits/std_thread.h:244
    #38 0x7f3c546ecdb3  (/lib/x86_64-linux-gnu/libstdc++.so.6+0xecdb3) (BuildId: ca77dae775ec87540acd7218fa990c40d1c94ab1)
    #39 0x7f3c5505ea41 in asan_thread_start ../../../../src/libsanitizer/asan/asan_interceptors.cpp:234
    #40 0x7f3c5429ca93  (/lib/x86_64-linux-gnu/libc.so.6+0x9ca93) (BuildId: 6d64b17fbac799e68da7ebd9985ddf9b5cb375e6)
    #41 0x7f3c54329c3b  (/lib/x86_64-linux-gnu/libc.so.6+0x129c3b) (BuildId: 6d64b17fbac799e68da7ebd9985ddf9b5cb375e6)

Address 0x7f3c4d7589d0 is located in stack of thread T509 at offset 80 in frame
    #0 0x55e2f3e0fe73 in firebase::firestore::util::FormatArg::FormatArg<firebase::firestore::remote::Stream const>(firebase::firestore::remote::Stream const*, firebase::firestore::util::internal::FormatChoice<4>) /home/runner/work/firebase-ios-sdk/firebase-ios-sdk/Firestore/core/src/util/string_format.h:128

  This frame has 2 object(s):
    [32, 48) '<unknown>'
    [64, 96) '<unknown>' <== Memory access at offset 80 is inside this variable
HINT: this may be a false positive if your program uses some custom stack unwind mechanism, swapcontext or vfork
      (longjmp and C++ exceptions *are* supported)
Thread T509 created by T0 here:
    #0 0x7f3c550f51f9 in pthread_create ../../../../src/libsanitizer/asan/asan_interceptors.cpp:245
    #1 0x7f3c546eceb0 in std::thread::_M_start_thread(std::unique_ptr<std::thread::_State, std::default_delete<std::thread::_State> >, void (*)()) (/lib/x86_64-linux-gnu/libstdc++.so.6+0xeceb0) (BuildId: ca77dae775ec87540acd7218fa990c40d1c94ab1)
    #2 0x55e2f3ff3496 in std::thread::thread<void (*)(std::shared_ptr<firebase::firestore::util::ExecutorStd::SharedState>), std::shared_ptr<firebase::firestore::util::ExecutorStd::SharedState>&, void>(void (*&&)(std::shared_ptr<firebase::firestore::util::ExecutorStd::SharedState>), std::shared_ptr<firebase::firestore::util::ExecutorStd::SharedState>&) /usr/include/c++/13/bits/std_thread.h:164
    #3 0x55e2f3ff15be in void std::__new_allocator<std::thread>::construct<std::thread, void (*)(std::shared_ptr<firebase::firestore::util::ExecutorStd::SharedState>), std::shared_ptr<firebase::firestore::util::ExecutorStd::SharedState>&>(std::thread*, void (*&&)(std::shared_ptr<firebase::firestore::util::ExecutorStd::SharedState>), std::shared_ptr<firebase::firestore::util::ExecutorStd::SharedState>&) /usr/include/c++/13/bits/new_allocator.h:191
    #4 0x55e2f3ff15be in void std::allocator_traits<std::allocator<std::thread> >::construct<std::thread, void (*)(std::shared_ptr<firebase::firestore::util::ExecutorStd::SharedState>), std::shared_ptr<firebase::firestore::util::ExecutorStd::SharedState>&>(std::allocator<std::thread>&, std::thread*, void (*&&)(std::shared_ptr<firebase::firestore::util::ExecutorStd::SharedState>), std::shared_ptr<firebase::firestore::util::ExecutorStd::SharedState>&) /usr/include/c++/13/bits/alloc_traits.h:538
    #5 0x55e2f3ff15be in void std::vector<std::thread, std::allocator<std::thread> >::_M_realloc_insert<void (*)(std::shared_ptr<firebase::firestore::util::ExecutorStd::SharedState>), std::shared_ptr<firebase::firestore::util::ExecutorStd::SharedState>&>(__gnu_cxx::__normal_iterator<std::thread*, std::vector<std::thread, std::allocator<std::thread> > >, void (*&&)(std::shared_ptr<firebase::firestore::util::ExecutorStd::SharedState>), std::shared_ptr<firebase::firestore::util::ExecutorStd::SharedState>&) /usr/include/c++/13/bits/vector.tcc:468
    #6 0x55e2f3ff01e0 in void std::vector<std::thread, std::allocator<std::thread> >::emplace_back<void (*)(std::shared_ptr<firebase::firestore::util::ExecutorStd::SharedState>), std::shared_ptr<firebase::firestore::util::ExecutorStd::SharedState>&>(void (*&&)(std::shared_ptr<firebase::firestore::util::ExecutorStd::SharedState>), std::shared_ptr<firebase::firestore::util::ExecutorStd::SharedState>&) /usr/include/c++/13/bits/vector.tcc:123
    #7 0x55e2f3fe979b in firebase::firestore::util::ExecutorStd::ExecutorStd(int) /home/runner/work/firebase-ios-sdk/firebase-ios-sdk/Firestore/core/src/util/executor_std.cc:67
    #8 0x55e2f3ff0b85 in std::__detail::_MakeUniq<firebase::firestore::util::ExecutorStd>::__single_object std::make_unique<firebase::firestore::util::ExecutorStd, int>(int&&) /usr/include/c++/13/bits/unique_ptr.h:1070
    #9 0x55e2f3feb732 in firebase::firestore::util::Executor::CreateSerial(char const*) /home/runner/work/firebase-ios-sdk/firebase-ios-sdk/Firestore/core/src/util/executor_std.cc:248
    #10 0x55e2f3f065c2 in firebase::firestore::testutil::ExecutorForTesting(char const*) /home/runner/work/firebase-ios-sdk/firebase-ios-sdk/Firestore/core/test/unit/testutil/async_testing.cc:51
    #11 0x55e2f3f06889 in firebase::firestore::testutil::AsyncQueueForTesting() /home/runner/work/firebase-ios-sdk/firebase-ios-sdk/Firestore/core/test/unit/testutil/async_testing.cc:55
    #12 0x55e2f3b7272e in firebase::firestore::remote::StreamTest::StreamTest() /home/runner/work/firebase-ios-sdk/firebase-ios-sdk/Firestore/core/test/unit/remote/stream_test.cc:151
    #13 0x55e2f3b79add in firebase::firestore::remote::StreamTest_ObserverReceivesStreamCloseOnError_Test::StreamTest_ObserverReceivesStreamCloseOnError_Test() /home/runner/work/firebase-ios-sdk/firebase-ios-sdk/Firestore/core/test/unit/remote/stream_test.cc:315
    #14 0x55e2f3b79b3f in testing::internal::TestFactoryImpl<firebase::firestore::remote::StreamTest_ObserverReceivesStreamCloseOnError_Test>::CreateTest() /home/runner/work/firebase-ios-sdk/firebase-ios-sdk/build/external/src/googletest/googletest/include/gtest/internal/gtest-internal.h:456
    #15 0x55e2f3c1a79a in testing::Test* testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::TestFactoryBase, testing::Test*>(testing::internal::TestFactoryBase*, testing::Test* (testing::internal::TestFactoryBase::*)(), char const*) /home/runner/work/firebase-ios-sdk/firebase-ios-sdk/build/external/src/googletest/googletest/src/gtest.cc:2653
    #16 0x55e2f3c08afc in testing::Test* testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::TestFactoryBase, testing::Test*>(testing::internal::TestFactoryBase*, testing::Test* (testing::internal::TestFactoryBase::*)(), char const*) /home/runner/work/firebase-ios-sdk/firebase-ios-sdk/build/external/src/googletest/googletest/src/gtest.cc:2689
    #17 0x55e2f3bb2b62 in testing::TestInfo::Run() /home/runner/work/firebase-ios-sdk/firebase-ios-sdk/build/external/src/googletest/googletest/src/gtest.cc:2864
    #18 0x55e2f3bb3d72 in testing::TestSuite::Run() /home/runner/work/firebase-ios-sdk/firebase-ios-sdk/build/external/src/googletest/googletest/src/gtest.cc:3052
    #19 0x55e2f3bdb31d in testing::internal::UnitTestImpl::RunAllTests() /home/runner/work/firebase-ios-sdk/firebase-ios-sdk/build/external/src/googletest/googletest/src/gtest.cc:6020
    #20 0x55e2f3c1dc5e in bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) /home/runner/work/firebase-ios-sdk/firebase-ios-sdk/build/external/src/googletest/googletest/src/gtest.cc:2653
    #21 0x55e2f3c0b0a5 in bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) (/home/runner/work/firebase-ios-sdk/firebase-ios-sdk/build/Firestore/core/test/unit/remote/firestore_remote_test+0xbff0a5) (BuildId: f7c12f95667149168e8d09e2d8dce95145d40cca)
    #22 0x55e2f3bd7ad1 in testing::UnitTest::Run() /home/runner/work/firebase-ios-sdk/firebase-ios-sdk/build/external/src/googletest/googletest/src/gtest.cc:5599
    #23 0x55e2f3c4d907 in RUN_ALL_TESTS() /home/runner/work/firebase-ios-sdk/firebase-ios-sdk/build/external/src/googletest/googletest/include/gtest/gtest.h:2334
    #24 0x55e2f3c4d853 in main /home/runner/work/firebase-ios-sdk/firebase-ios-sdk/build/external/src/googletest/googletest/src/gtest_main.cc:64
    #25 0x7f3c5422a1c9  (/lib/x86_64-linux-gnu/libc.so.6+0x2a1c9) (BuildId: 6d64b17fbac799e68da7ebd9985ddf9b5cb375e6)
    #26 0x7f3c5422a28a in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x2a28a) (BuildId: 6d64b17fbac799e68da7ebd9985ddf9b5cb375e6)
    #27 0x55e2f38ab5e4 in _start (/home/runner/work/firebase-ios-sdk/firebase-ios-sdk/build/Firestore/core/test/unit/remote/firestore_remote_test+0x89f5e4) (BuildId: f7c12f95667149168e8d09e2d8dce95145d40cca)

SUMMARY: AddressSanitizer: stack-use-after-return ../../../../src/libsanitizer/sanitizer_common/sanitizer_common_interceptors.inc:391 in strlen
Shadow bytes around the buggy address:
  0x7f3c4d758700: f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5
  0x7f3c4d758780: f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 00 00 00 00
  0x7f3c4d758800: f1 f1 f1 f1 00 f2 f2 f2 00 00 00 00 f3 f3 f3 f3
  0x7f3c4d758880: f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5
  0x7f3c4d758900: f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 00 00 00 00
=>0x7f3c4d758980: f5 f5 f5 f5 f5 f5 f5 f5 f5 f5[f5]f5 f5 f5 f5 f5
  0x7f3c4d758a00: f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 00 00 00 00
  0x7f3c4d758a80: f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 00 00 00 00
  0x7f3c4d758b00: f1 f1 f1 f1 00 00 f2 f2 00 00 00 00 f3 f3 f3 f3
  0x7f3c4d758b80: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x7f3c4d758c00: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
Shadow byte legend (one shadow byte represents 8 application bytes):
  Addressable:           00
  Partially addressable: 01 02 03 04 05 06 07 
  Heap left redzone:       fa
  Freed heap region:       fd
  Stack left redzone:      f1
  Stack mid redzone:       f2
  Stack right redzone:     f3
  Stack after return:      f5
  Stack use after scope:   f8
  Global redzone:          f9
  Global init order:       f6
  Poisoned by user:        f7
  Container overflow:      fc
  Array cookie:            ac
  Intra object redzone:    bb
  ASan internal:           fe
  Left alloca redzone:     ca
  Right alloca redzone:    cb
==22279==ABORTING
Test #10: firestore_remote_test ............***Failed    5.65 sec

Failure 2: firestore_util_test

[ RUN      ] StringFormatTest.Pointer
=================================================================
==22799==ERROR: AddressSanitizer: stack-use-after-return on address 0x7fd81274d850 at pc 0x7fd8156fb42e bp 0x7fff199f7000 sp 0x7fff199f67a8
READ of size 12 at 0x7fd81274d850 thread T0
    #0 0x7fd8156fb42d in memcpy ../../../../src/libsanitizer/sanitizer_common/sanitizer_common_interceptors_memintrinsics.inc:115
    #1 0x7fd814d68754 in std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_mutate(unsigned long, unsigned long, char const*, unsigned long) (/lib/x86_64-linux-gnu/libstdc++.so.6+0x168754) (BuildId: ca77dae775ec87540acd7218fa990c40d1c94ab1)
    #2 0x7fd814d6a04f in std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_append(char const*, unsigned long) (/lib/x86_64-linux-gnu/libstdc++.so.6+0x16a04f) (BuildId: ca77dae775ec87540acd7218fa990c40d1c94ab1)
    #3 0x55b3e2a2ab80 in operator() /home/runner/work/firebase-ios-sdk/firebase-ios-sdk/Firestore/core/src/util/string_format.cc:51
    #4 0x55b3e2a2b073 in operator() /home/runner/work/firebase-ios-sdk/firebase-ios-sdk/Firestore/core/src/util/string_format.cc:75
    #5 0x55b3e2a2b275 in firebase::firestore::util::internal::StringFormatPieces[abi:cxx11](char const*, std::initializer_list<absl::lts_20240116::string_view>) /home/runner/work/firebase-ios-sdk/firebase-ios-sdk/Firestore/core/src/util/string_format.cc:109
    #6 0x55b3e26aac42 in std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > firebase::firestore::util::StringFormat<int*>(char const*, int* const&) /home/runner/work/firebase-ios-sdk/firebase-ios-sdk/Firestore/core/src/util/string_format.h:161
    #7 0x55b3e26a32cc in firebase::firestore::util::StringFormatTest_Pointer_Test::TestBody() /home/runner/work/firebase-ios-sdk/firebase-ios-sdk/Firestore/core/test/unit/util/string_format_test.cc:79
    #8 0x55b3e27ed182 in void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) /home/runner/work/firebase-ios-sdk/firebase-ios-sdk/build/external/src/googletest/googletest/src/gtest.cc:2653
    #9 0x55b3e27dc194 in void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) /home/runner/work/firebase-ios-sdk/firebase-ios-sdk/build/external/src/googletest/googletest/src/gtest.cc:2689
    #10 0x55b3e2786e35 in testing::Test::Run() /home/runner/work/firebase-ios-sdk/firebase-ios-sdk/build/external/src/googletest/googletest/src/gtest.cc:2728
    #11 0x55b3e27884ac in testing::TestInfo::Run() /home/runner/work/firebase-ios-sdk/firebase-ios-sdk/build/external/src/googletest/googletest/src/gtest.cc:2874
    #12 0x55b3e278967e in testing::TestSuite::Run() /home/runner/work/firebase-ios-sdk/firebase-ios-sdk/build/external/src/googletest/googletest/src/gtest.cc:3052
    #13 0x55b3e27b0c29 in testing::internal::UnitTestImpl::RunAllTests() /home/runner/work/firebase-ios-sdk/firebase-ios-sdk/build/external/src/googletest/googletest/src/gtest.cc:6020
    #14 0x55b3e27f0732 in bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) /home/runner/work/firebase-ios-sdk/firebase-ios-sdk/build/external/src/googletest/googletest/src/gtest.cc:2653
    #15 0x55b3e27def71 in bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) /home/runner/work/firebase-ios-sdk/firebase-ios-sdk/build/external/src/googletest/googletest/src/gtest.cc:2689
    #16 0x55b3e27ad3dd in testing::UnitTest::Run() /home/runner/work/firebase-ios-sdk/firebase-ios-sdk/build/external/src/googletest/googletest/src/gtest.cc:5599
    #17 0x55b3e281da4b in RUN_ALL_TESTS() /home/runner/work/firebase-ios-sdk/firebase-ios-sdk/build/external/src/googletest/googletest/include/gtest/gtest.h:2334
    #18 0x55b3e281d997 in main /home/runner/work/firebase-ios-sdk/firebase-ios-sdk/build/external/src/googletest/googletest/src/gtest_main.cc:64
    #19 0x7fd81482a1c9  (/lib/x86_64-linux-gnu/libc.so.6+0x2a1c9) (BuildId: 6d64b17fbac799e68da7ebd9985ddf9b5cb375e6)
    #20 0x7fd81482a28a in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x2a28a) (BuildId: 6d64b17fbac799e68da7ebd9985ddf9b5cb375e6)
    #21 0x55b3e22e0074 in _start (/home/runner/work/firebase-ios-sdk/firebase-ios-sdk/build/Firestore/core/test/unit/util/firestore_util_test+0x14d074) (BuildId: 40b5157b4e6df54ceafbfc2f9b93bba30229c5c6)

Address 0x7fd81274d850 is located in stack of thread T0 at offset 80 in frame
    #0 0x55b3e26ad899 in firebase::firestore::util::FormatArg::FormatArg<int>(int*, firebase::firestore::util::internal::FormatChoice<4>) /home/runner/work/firebase-ios-sdk/firebase-ios-sdk/Firestore/core/src/util/string_format.h:128

  This frame has 2 object(s):
    [32, 48) '<unknown>'
    [64, 96) '<unknown>' <== Memory access at offset 80 is inside this variable
HINT: this may be a false positive if your program uses some custom stack unwind mechanism, swapcontext or vfork
      (longjmp and C++ exceptions *are* supported)
SUMMARY: AddressSanitizer: stack-use-after-return ../../../../src/libsanitizer/sanitizer_common/sanitizer_common_interceptors_memintrinsics.inc:115 in memcpy
Shadow bytes around the buggy address:
  0x7fd81274d580: f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 00 00 00 00
  0x7fd81274d600: f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 00 00 00 00
  0x7fd81274d680: f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 00 00 00 00
  0x7fd81274d700: f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 00 00 00 00
  0x7fd81274d780: f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 00 00 00 00
=>0x7fd81274d800: f5 f5 f5 f5 f5 f5 f5 f5 f5 f5[f5]f5 f5 f5 f5 f5
  0x7fd81274d880: f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 00 00 00 00
  0x7fd81274d900: f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 00 00 00 00
  0x7fd81274d980: f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 00 00 00 00
  0x7fd81274da00: f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 00 00 00 00
  0x7fd81274da80: f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 00 00 00 00
Shadow byte legend (one shadow byte represents 8 application bytes):
  Addressable:           00
  Partially addressable: 01 02 03 04 05 06 07 
  Heap left redzone:       fa
  Freed heap region:       fd
  Stack left redzone:      f1
  Stack mid redzone:       f2
  Stack right redzone:     f3
  Stack after return:      f5
  Stack use after scope:   f8
  Global redzone:          f9
  Global init order:       f6
  Poisoned by user:        f7
  Container overflow:      fc
  Array cookie:            ac
  Intra object redzone:    bb
  ASan internal:           fe
  Left alloca redzone:     ca
  Right alloca redzone:    cb
==22799==ABORTING
Test #11: firestore_util_test ..............***Failed   11.99 sec

@dconeybe dconeybe marked this pull request as ready for review January 3, 2025 15:25
@dconeybe dconeybe merged commit ffe6cf2 into main Jan 3, 2025
35 of 36 checks passed
@dconeybe dconeybe deleted the dconeybe/GHAPy37 branch January 3, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants