[WIP] Streamable functions #14395

ncooke3 · 2025-01-29T15:02:14Z

Contribution Workflow

Fork the Firebase repo and clone it.
Add Upstream: git remote add upstream https://github.com/firebase/firebase-ios-sdk.git
Create Branch: git fetch upstream && git checkout -b <feature-branch> upstream/streamable-functions
- Where <feature-branch> is the name of the branch (e.g., add-tests-streamable).
Regular workflow: Run style script and git add . && git commit -m "..."
Push: git push origin <feature-branch>
PR: Create a PR on GitHub, with base branch set tofirebase:streamable-functions
Update fork feature branch (if needed):

git fetch upstream
git checkout <feature-branch>
git merge upstream/streamable-functions
git push origin <feature-branch>

…14051)

Add initial support for Streamable functions.

Change call to AsyncThrowingStream<HTTPSCallableResult, Error>

testing check.sh

Remove old test function.

Remove old test

Add a full working test for stremableFunction. Refactor.

Add Json capabilities to parse an HTTP result back and forth. Updating Unit tests.

Cleanup

Add doc for processResponseDataForStreamableContent.

Update func to have a callback. Update UnitTests

Remove test.

Remove spaces.

Fetch Main branch.

Project clean up.

…/firebase-ios-sdk into iOS-Stremable-Functions

Updated to renamed code. From callableResultFromResponse to callableResult

Run style.sh

Fix concurrency " mutation of captured var 'response' in concurrently-executing code" and typos.

Co-authored-by: Nick Cooke <36927374+ncooke3@users.noreply.github.com>

This file is not needed.

Add throws Remove DO - CATCH

google-oss-bot · 2025-01-29T15:03:22Z

	1 Warning
⚠️	Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

github-actions · 2025-01-29T15:06:21Z

Apple API Diff Report

Commit: 93d2734
Last updated: Mon Feb 3 13:26 PST 2025
View workflow logs & download artifacts

FirebaseFunctions

Structures

Callable

[ADDED] stream(_:)

Swift:
+  public func stream ( _ data : Request ) -> AsyncThrowingStream < Response , Error >

…e network calls are done. Co-authored-by: Eblen M <eblenmacari@gmail.com> Co-authored-by: Author: Nick Cooke <nickcooke@google.com>

Need to add UnitTests here. Co-authored-by: Eblen M <eblenmacari@gmail.com> Co-authored-by: Nick Cooke <nickcooke@google.com>

Co-authored-by: Eblen M <eblenmacari@gmail.com> Co-authored-by: Nick Cooke <nickcooke@google.com>

Typo fix.

Add new case for genStreamError Co-authored-by: Eblen M <eblenmacari@gmail.com> Co-authored-by: Nick Cooke <nickcooke@google.com>

eBlender and others added 30 commits December 19, 2024 14:32

[Infra] Update functions workflow to use macOS 15 for Xcode 16 jobs (#…

231d602

…14051)

Stremable Functions.

a14d964

Add initial support for Streamable functions.

Changed return type.

a92d7c2

Change call to AsyncThrowingStream<HTTPSCallableResult, Error>

Lint test

10bec1d

testing check.sh

Remove test function

53a2aab

Remove old test function.

Remove old test.

758fbed

Remove old test

Updated function, add full test.

93b6c8b

Add a full working test for stremableFunction. Refactor.

Update functions

a7e8fe8

Add Json capabilities to parse an HTTP result back and forth. Updating Unit tests.

Update FunctionsTests.swift

6d59fcd

Cleanup HTTPCallable

51f02b8

Cleanup

Add documentation for processResponseDataForStreamableContent

7b61076

Add doc for processResponseDataForStreamableContent.

Update Functions.swift

a95449e

Update Functions.swift

cdc49ee

Update FunctionsTests.swift

426b6bc

Update and Cleanup

9cb0a5e

Update func to have a callback. Update UnitTests

Update IntegrationTests.swift

ad31052

Remove test.

Clean up

6ee9000

Remove spaces.

Update check.sh

1ffe73d

Bump to Main.

9fcd91e

Fetch Main branch.

Merge branch 'main' into iOS-Stremable-Functions

177aa8e

Cleanup

f4d678b

Project clean up.

Merge branch 'iOS-Stremable-Functions' of https://github.com/eBlender…

74557e7

…/firebase-ios-sdk into iOS-Stremable-Functions

Update Functions.swift

18f748b

Updated to renamed code. From callableResultFromResponse to callableResult

Lint check

4f956fb

Run style.sh

Function concurrency error

4edc0ad

Fix concurrency " mutation of captured var 'response' in concurrently-executing code" and typos.

Update .github/workflows/functions.yml

e50f69c

Co-authored-by: Nick Cooke <36927374+ncooke3@users.noreply.github.com>

Update FirebaseFunctions/Tests/Unit/FunctionsTests.swift

7356cf9

Co-authored-by: Nick Cooke <36927374+ncooke3@users.noreply.github.com>

Delete firebase-database-emulator.log

aed47d6

This file is not needed.

Delete firebase-database-emulator.pid

f6c6cff

This file is not needed.

Update function error handling.

75a7574

Add throws Remove DO - CATCH

ncooke3 added 3 commits January 27, 2025 11:12

Merge remote-tracking branch 'origin/main' into iOS-Stremable-Functions

6dc3959

Post main sync checkpoint

ca53153

Copy over more structure from vertex

d3e476c

google-oss-bot added the api: functions label Jan 29, 2025

github-actions bot added the public-api-change label Jan 29, 2025

Updated to changes in 14376 so the impl is closer to Vertex on how th…

e33f74c

…e network calls are done. Co-authored-by: Eblen M <eblenmacari@gmail.com> Co-authored-by: Author: Nick Cooke <nickcooke@google.com>

github-actions bot added public-api-change and removed public-api-change labels Jan 29, 2025

eBlender and others added 4 commits January 29, 2025 10:31

Update - remove tests

b98f71d

Need to add UnitTests here. Co-authored-by: Eblen M <eblenmacari@gmail.com> Co-authored-by: Nick Cooke <nickcooke@google.com>

Add Documentation.

0ea118f

Co-authored-by: Eblen M <eblenmacari@gmail.com> Co-authored-by: Nick Cooke <nickcooke@google.com>

Update Functions.swift

20892fd

Typo fix.

Update IntegrationTests.swift

83eae53

Add new case for genStreamError Co-authored-by: Eblen M <eblenmacari@gmail.com> Co-authored-by: Nick Cooke <nickcooke@google.com>

ncooke3 closed this Jan 29, 2025

ncooke3 reopened this Jan 29, 2025

ncooke3 mentioned this pull request Jan 29, 2025

Streamable HTTPCallable functions #14290

Closed

github-actions bot added public-api-change and removed public-api-change labels Jan 29, 2025

Add more integration tests

749b52d

github-actions bot added public-api-change and removed public-api-change labels Jan 29, 2025

Remove unneeded code

480f7c3

github-actions bot removed the public-api-change label Jan 29, 2025

ncooke3 added 2 commits January 29, 2025 11:11

Fix comments

5587eb7

Rename internal stream API

078210e

github-actions bot added the public-api-change label Jan 29, 2025

818Nawaf approved these changes Jan 30, 2025

View reviewed changes

github-actions bot added public-api-change and removed public-api-change labels Feb 3, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] Streamable functions #14395

[WIP] Streamable functions #14395

ncooke3 commented Jan 29, 2025 •

edited

Loading

google-oss-bot commented Jan 29, 2025

github-actions bot commented Jan 29, 2025 •

edited

Loading

[WIP] Streamable functions #14395

Are you sure you want to change the base?

[WIP] Streamable functions #14395

Conversation

ncooke3 commented Jan 29, 2025 • edited Loading

google-oss-bot commented Jan 29, 2025

github-actions bot commented Jan 29, 2025 • edited Loading

Apple API Diff Report

FirebaseFunctions

Structures

Callable

ncooke3 commented Jan 29, 2025 •

edited

Loading

github-actions bot commented Jan 29, 2025 •

edited

Loading