[Firebase AI] Fix Chat history append locking
#15115
Conversation
This commit introduces a new `appendHistory` method to the `Chat` class to provide a thread-safe way of appending to the chat history. The following changes were made: - A new `appendHistory` method was added to the `Chat` class. - All direct calls to `history.append` were replaced with calls to the new `appendHistory` method. This ensures that all modifications to the chat history are protected by a lock, preventing potential race conditions.
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback. |
3 participants
Added an
appendHistorymethod to theChatclass and replaced all direct calls tohistory.appendwithappendHistory. Theappendcall on thehistoryarray is mutating and it was occurring outside the lock.Note:
Chatstill isn't completely thread-safe since parallelsendMessageorsendMessageStreamcalls could update the history in an arbitrary order.#no-changelog