- 
                Notifications
    
You must be signed in to change notification settings  - Fork 1.7k
 
fix(ci): Update the AI integration test secrets #15397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
          Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either  
 Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a  Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @daymxn! I think it would be good to move these files (and scripts/gha-encrypted/VertexAI/TestApp-Credentials.swift.gpg) to a FirebaseAI directory. Alternatively, we could merge as is and move them in a follow-up PR.
I noticed that the firebaseai workflow didn't run on this PR so I kicked it off manually. After we move the files (either in this PR or a follow-up), I think we should add scripts/gha-encrypted/FirebaseAI/ to: 
firebase-ios-sdk/.github/workflows/firebaseai.yml
Lines 4 to 14 in abf5e55
| pull_request: | |
| paths: | |
| - 'FirebaseAI**' | |
| - '.github/workflows/firebaseai.yml' | |
| - '.github/workflows/common.yml' | |
| - '.github/workflows/common_cocoapods.yml' | |
| - 'scripts/quickstart_build_spm.sh' | |
| - 'scripts/update_firebase_spm_dependency.sh' | |
| - 'Gemfile*' | |
| # Do not run for documentation-only PRs. | |
| - '!**.md' | 
Let me know which approach you'd prefer. This LGTM once we verify that the integration tests pass (it passed).
        
          
                scripts/gha-encrypted/FirebaseAI/TestApp-GoogleService-Info-Spark.plist.gpg
          
            Show resolved
            Hide resolved
        
      There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This PR updates the encrypted
GoogleService-Info.plistfiles for the AI integration tests; aligning them with the new bundle ID (com.google.firebase.FirebaseAITestApp).#no-changelog