Skip to content

Conversation

@daymxn
Copy link
Member

@daymxn daymxn commented Oct 20, 2025

Per b/448671945,

This adds support for the sendVideoRealtime function on LiveSession. More specifically, it's now public instead of internal. After further testing, the docs have been updated to reflect its intended use-case (sending image frames of the video, instead of raw video data).

A test has also been added to our integration tests which verifies that sending videos via sendVideoRealtime works as intended.

@daymxn daymxn requested review from andrewheard and ncooke3 October 20, 2025 18:46
@daymxn daymxn self-assigned this Oct 20, 2025
@gemini-code-assist
Copy link
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

@andrewheard
Copy link
Contributor

/gemini review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully adds support for sending video frames via the LiveSession API by making the sendVideoRealtime function public and updating its documentation. The inclusion of an integration test and a utility for extracting video frames is a great addition that ensures the feature works as intended. I have a few minor suggestions to improve code clarity and style.

@daymxn daymxn requested a review from andrewheard October 20, 2025 19:18
rlazo added a commit to firebase/firebase-android-sdk that referenced this pull request Oct 21, 2025
The doc must accurately describe that the expected data is a video *frame* rather than actual video data.

Description is aligned to the iOS description from firebase/firebase-ios-sdk#15432
rlazo added a commit to firebase/firebase-android-sdk that referenced this pull request Oct 21, 2025
The doc must accurately describe that the expected data is a video
*frame* rather than actual video data.

Description is aligned to the iOS description from
firebase/firebase-ios-sdk#15432
@daymxn daymxn enabled auto-merge (squash) October 21, 2025 21:41
@daymxn daymxn merged commit be30d46 into main Oct 21, 2025
63 checks passed
@daymxn daymxn deleted the dlr/make-realtime-video-public branch October 21, 2025 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants