-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(ai): Add support for sending videos via Live API. #15432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. |
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request successfully adds support for sending video frames via the LiveSession API by making the sendVideoRealtime function public and updating its documentation. The inclusion of an integration test and a utility for extracting video frames is a great addition that ensures the feature works as intended. I have a few minor suggestions to improve code clarity and style.
The doc must accurately describe that the expected data is a video *frame* rather than actual video data. Description is aligned to the iOS description from firebase/firebase-ios-sdk#15432
The doc must accurately describe that the expected data is a video *frame* rather than actual video data. Description is aligned to the iOS description from firebase/firebase-ios-sdk#15432
Per b/448671945,
This adds support for the
sendVideoRealtimefunction onLiveSession. More specifically, it's now public instead of internal. After further testing, the docs have been updated to reflect its intended use-case (sending image frames of the video, instead of raw video data).A test has also been added to our integration tests which verifies that sending videos via
sendVideoRealtimeworks as intended.