-
Notifications
You must be signed in to change notification settings - Fork 1.7k
infra(ci): Add run command to integ test script #15433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. |
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new run
command to the integration test script, which is a great addition for local testing. The command is well-documented and includes useful features like automatic Xcode version detection and secret file management. My review includes a few suggestions to improve code quality and fix a minor logging issue. Specifically, I've pointed out the use of a deprecated API, a small bug in logger configuration, and an opportunity to refactor how a subcommand is invoked for better readability and maintainability.
This adds a new command to the
test
subcommand within therepo
script calledrun
which will automatically run integration tests locally. It also provides a way to specify secret files via ajson
file, which will be automatically decrypted and deleted after the test runs (depending on theoverwrite
command). Docs have been included with the command to explain this and more.The github workflow for running Firebase AI integration tests has also been updated to use this script, to ensure we keep it up-to-date in the future.
Example command usage:
#no-changelog