Skip to content

Conversation

@paulb777
Copy link
Member

Fix #6091

@gemini-code-assist
Copy link
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

@paulb777
Copy link
Member Author

/gemini review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes an issue with the password reset process, particularly for scenarios like Sign-in with Apple where a custom authentication domain is used. The change correctly uses the customAuthDomain as a fallback for the linkDomain in ActionCodeSettings. The implementation is clean and is accompanied by a new unit test. I've suggested an improvement to the tests to cover more edge cases for better robustness. Overall, this is a good change.

@paulb777 paulb777 requested review from ncooke3 and pashanka December 1, 2025 14:23
@ncooke3 ncooke3 self-assigned this Dec 2, 2025
@paulb777
Copy link
Member Author

paulb777 commented Dec 2, 2025

Closing based on #6091 (comment)

@paulb777 paulb777 closed this Dec 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Not receiving password reset emails from firebase account that uses Sign In With Apple

3 participants