Rework the IWYU test to handle types with multiple valid sources #2633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
var-const
approved these changes
Mar 25, 2019
scripts/cpplint.py
Outdated
| 'build/include_what_you_use', 4, | ||
| 'Add #include ' + required_header_unstripped + ' for ' + template) | ||
| 'Add #include ' + preferred_header + ' for ' + template) |
There was a problem hiding this comment.
Very optional: ideally, I'd output the alternatives as well, not only the preferred_header. Feel free to ignore if it's annoying to implement.
There was a problem hiding this comment.
Now outputs:
Firestore/core/test/firebase/firestore/testutil/xcgmock.h:103: Add #include <iosfwd> for ostream (or <ostream>, <iostream>) [build/include_what_you_use] [4]
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This handles
#include <iostream>in xcgmock.h.The previous implementation failed because it required
<iosfwd>to be included from headers, even though<iostream>or<ostream>is sufficient.This essentially changes the algorithm to ensure that individual entities have their headers covered rather than compiling a list of required headers. The latter is no longer computable if we allow this flexibility.