Add CJS browser entry points for all packages (#6981)

firebase · Jan 31, 2023 · 0bab0b7 · 0bab0b7
1 parent 27b5e7d
commit 0bab0b7
Show file tree

Hide file tree

Showing 28 changed files with 393 additions and 56 deletions.
diff --git a/.changeset/ninety-taxis-study.md b/.changeset/ninety-taxis-study.md
@@ -0,0 +1,19 @@
+---
+'@firebase/auth': patch
+'@firebase/auth-compat': patch
+'@firebase/database': patch
+'@firebase/database-compat': patch
+'firebase': patch
+'@firebase/firestore': patch
+'@firebase/firestore-compat': patch
+'@firebase/functions': patch
+'@firebase/functions-compat': patch
+'@firebase/messaging': patch
+'@firebase/messaging-compat': patch
+'@firebase/rules-unit-testing': patch
+'@firebase/storage': patch
+'@firebase/template': patch
+'@firebase/util': patch
+---
+
+Added browser CJS entry points (expected by Jest when using JSDOM mode).
diff --git a/packages/auth-compat/package.json b/packages/auth-compat/package.json
@@ -16,7 +16,11 @@
         "require": "./dist/index.node.cjs.js"
       },
       "esm5": "./dist/index.esm.js",
-      "default": "./dist/index.esm2017.js"
+      "default": "./dist/index.esm2017.js",
+      "browser": {
+        "require": "./dist/index.cjs.js",
+        "import": "./dist/index.esm2017.js"
+      }
     },
     "./package.json": "./package.json"
   },

diff --git a/packages/auth-compat/rollup.config.js b/packages/auth-compat/rollup.config.js
@@ -73,6 +73,19 @@ const browserBuilds = [
     treeshake: {
       moduleSideEffects: false
     }
+  },
+  {
+    input: 'index.ts',
+    output: {
+      file: 'dist/index.cjs.js',
+      format: 'cjs',
+      sourcemap: true
+    },
+    plugins: es2017BuildPlugins,
+    external: id => deps.some(dep => id === dep || id.startsWith(`${dep}/`)),
+    treeshake: {
+      moduleSideEffects: false
+    }
   }
 ];
 

diff --git a/packages/auth/package.json b/packages/auth/package.json
@@ -31,7 +31,11 @@
         "default": "./dist/index.webworker.esm5.js"
       },
       "esm5": "./dist/esm5/index.js",
-      "default": "./dist/esm2017/index.js"
+      "default": "./dist/esm2017/index.js",
+      "browser": {
+        "require": "./dist/browser-cjs/index.js",
+        "import": "./dist/esm2017/index.js"
+      }
     },
     "./cordova": {
       "types": "./dist/cordova/index.cordova.d.ts",
@@ -57,7 +61,11 @@
         "default": "./dist/cordova/internal.js"
       },
       "esm5": "./dist/esm5/internal.js",
-      "default": "./dist/esm2017/internal.js"
+      "default": "./dist/esm2017/internal.js",
+      "browser": {
+        "require": "./dist/browser-cjs/internal.js",
+        "import": "./dist/esm2017/internal.js"
+      }
     },
     "./package.json": "./package.json"
   },

diff --git a/packages/auth/rollup.config.js b/packages/auth/rollup.config.js
@@ -97,6 +97,18 @@ const browserBuilds = [
       replace(generateBuildTargetReplaceConfig('esm', 2017))
     ],
     external: id => deps.some(dep => id === dep || id.startsWith(`${dep}/`))
+  },
+  {
+    input: {
+      index: 'index.ts',
+      internal: 'internal/index.ts'
+    },
+    output: [{ dir: 'dist/browser-cjs', format: 'cjs', sourcemap: true }],
+    plugins: [
+      ...es2017BuildPlugins,
+      replace(generateBuildTargetReplaceConfig('cjs', 2017))
+    ],
+    external: id => deps.some(dep => id === dep || id.startsWith(`${dep}/`))
   }
 ];
 

diff --git a/packages/database-compat/package.json b/packages/database-compat/package.json
@@ -22,7 +22,11 @@
         "require": "./dist/index.js"
       },
       "esm5": "./dist/index.esm5.js",
-      "default": "./dist/index.esm2017.js"
+      "default": "./dist/index.esm2017.js",
+      "browser": {
+        "require": "./dist/index.js",
+        "import": "./dist/index.esm2017.js"
+      }
     },
     "./standalone": {
       "types": "./dist/database-compat/src/index.standalone.d.ts",
@@ -64,4 +68,4 @@
   "bugs": {
     "url": "https://github.com/firebase/firebase-js-sdk/issues"
   }
-}
+}
diff --git a/packages/database/package.json b/packages/database/package.json
@@ -17,7 +17,11 @@
       },
       "esm5": "./dist/index.esm5.js",
       "standalone": "./dist/index.standalone.js",
-      "default": "./dist/index.esm2017.js"
+      "default": "./dist/index.esm2017.js",
+      "browser": {
+        "require": "./dist/index.cjs.js",
+        "import": "./dist/index.esm2017.js"
+      }
     },
     "./package.json": "./package.json"
   },

diff --git a/packages/database/rollup.config.js b/packages/database/rollup.config.js
@@ -94,6 +94,25 @@ const browserBuilds = [
     },
     external: id => deps.some(dep => id === dep || id.startsWith(`${dep}/`)),
     onwarn: onWarn
+  },
+  {
+    input: 'src/index.ts',
+    output: [
+      {
+        file: 'dist/index.cjs.js',
+        format: 'cjs',
+        sourcemap: true
+      }
+    ],
+    plugins: [
+      ...es2017BuildPlugins,
+      replace(generateBuildTargetReplaceConfig('cjs', 2017))
+    ],
+    treeshake: {
+      moduleSideEffects: false
+    },
+    external: id => deps.some(dep => id === dep || id.startsWith(`${dep}/`)),
+    onwarn: onWarn
   }
 ];