Remove gcEnabled for multitab test (#7234)

firebase · Apr 19, 2023 · 41f06be · 41f06be
1 parent 0a27d2f
commit 41f06be
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 9 deletions.
diff --git a/packages/firestore/test/unit/specs/limbo_spec.test.ts b/packages/firestore/test/unit/specs/limbo_spec.test.ts
@@ -425,7 +425,7 @@ describeSpec('Limbo Documents:', [], () => {
       const docB = doc('collection/b', 1001, { key: 'b' });
       const deletedDocB = deletedDoc('collection/b', 1005);
 
-      return client(0, false)
+      return client(0)
         .expectPrimaryState(true)
         .client(1)
         .userListens(query1)
@@ -463,7 +463,7 @@ describeSpec('Limbo Documents:', [], () => {
       const deletedDocB = deletedDoc('collection/b', 1006);
       const deletedDocC = deletedDoc('collection/c', 1008);
 
-      return client(0, false)
+      return client(0)
         .expectPrimaryState(true)
         .userListens(query1)
         .watchAcksFull(query1, 1 * 1e6, docA, docB, docC)

diff --git a/packages/firestore/test/unit/specs/listen_spec.test.ts b/packages/firestore/test/unit/specs/listen_spec.test.ts
@@ -845,7 +845,7 @@ describeSpec('Listens:', [], () => {
     const docA = doc('collection/a', 1000, { key: 'a' });
     const docB = doc('collection/b', 2000, { key: 'a' });
 
-    return client(0, /* withGcEnabled= */ false)
+    return client(0)
       .becomeVisible()
       .client(1)
       .userListens(query1)
@@ -1754,7 +1754,7 @@ describeSpec('Listens:', [], () => {
     () => {
       const query1 = query('collection');
       return (
-        client(0, /* withGcEnabled= */ false)
+        client(0)
           // Populate the cache with the empty query results.
           .userListens(query1)
           .watchAcksFull(query1, 1000)
@@ -1785,7 +1785,7 @@ describeSpec('Listens:', [], () => {
       const doc1Deleted = deletedDoc('collection/a', 2000);
 
       return (
-        client(0, /* withGcEnabled= */ false)
+        client(0)
           // Populate the cache with the empty query results.
           .userListens(query1)
           .watchAcksFull(query1, 1000, doc1)

diff --git a/packages/firestore/test/unit/specs/spec_builder.ts b/packages/firestore/test/unit/specs/spec_builder.ts
@@ -1252,10 +1252,7 @@ export function spec(): SpecBuilder {
 
 /** Starts a new multi-client SpecTest. */
 // PORTING NOTE: Only used by web multi-tab tests.
-export function client(
-  num: number,
-  withGcEnabled?: boolean
-): MultiClientSpecBuilder {
+export function client(num: number): MultiClientSpecBuilder {
   const specBuilder = new MultiClientSpecBuilder();
   specBuilder.ensureManualLruGC();
   return specBuilder.client(num);