rename unit test

firebase · Feb 20, 2025 · 9653bdc · 9653bdc
1 parent 48a5d6a
commit 9653bdc
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/packages/firestore/src/util/misc.ts b/packages/firestore/src/util/misc.ts
@@ -89,16 +89,17 @@ export function compareUtf8Strings(left: string, right: string): number {
         // Lazy instantiate TextEncoder
         const encoder = newTextEncoder();
 
+        // Substring and do UTF-8 encoded byte comparison
         const leftBytes = encoder.encode(getUtf8SafeSubstring(left, i));
         const rightBytes = encoder.encode(getUtf8SafeSubstring(right, i));
         for (
           let j = 0;
           j < Math.min(leftBytes.length, rightBytes.length);
           j++
         ) {
-          const comparison = primitiveComparator(leftBytes[j], rightBytes[j]);
-          if (comparison !== 0) {
-            return comparison;
+          const comp = primitiveComparator(leftBytes[j], rightBytes[j]);
+          if (comp !== 0) {
+            return comp;
           }
         }
       }

diff --git a/packages/firestore/test/unit/util/misc.test.ts b/packages/firestore/test/unit/util/misc.test.ts
@@ -267,7 +267,7 @@ class StringBuilder {
 }
 
 describe('CompareUtf8Strings', () => {
-  it('testCompareUtf8Strings', () => {
+  it('compareUtf8Strings should return correct results', () => {
     const errors = [];
     const seed = Math.floor(Math.random() * Number.MAX_SAFE_INTEGER);
     let passCount = 0;