Skip to content

auto-init auth-internal after initializing auth #5071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Feiyang1 merged 2 commits into from
Jun 28, 2021
Merged

auto-init auth-internal after initializing auth #5071

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
943a3fc
auto-init auth-internal after initializing auth
Feiyang1 Jun 25, 2021
4773d3e
Create sixty-masks-wash.md
Feiyang1 Jun 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/sixty-masks-wash.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"@firebase/auth": patch
"@firebase/component": patch
---

Auto initialize `auth-internal` after `auth` has been initialized.
11 changes: 10 additions & 1 deletion packages/auth/src/exports_auth.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -761,7 +761,16 @@ fireauth.exportlib.exportFunction(
'multipleInstances': false,
'serviceProps': namespace,
'instantiationMode': 'LAZY',
'type': 'PUBLIC'
'type': 'PUBLIC',
/**
* Initialize auth-internal after auth is initialized to make auth available to other firebase products.
*/
'onInstanceCreated': function (container, _instanceIdentifier, _instance) {
const authInternalProvider = container['getProvider'](
'auth-internal'
);
authInternalProvider['initialize']();
}
};

// Provides Auth internal APIs.
Expand Down
9 changes: 7 additions & 2 deletions packages/component/src/provider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,8 +251,6 @@ export class Provider<T extends Name> {
}
}

this.invokeOnInitCallbacks(instance, normalizedIdentifier);

return instance;
}

Expand Down Expand Up @@ -318,6 +316,13 @@ export class Provider<T extends Name> {
});
this.instances.set(instanceIdentifier, instance);

/**
* Invoke onInit listeners.
* Note this.component.onInstanceCreated is different, which is used by the component creator,
* while onInit listeners are registered by consumers of the provider.
*/
this.invokeOnInitCallbacks(instance, instanceIdentifier);

/**
* Order is important
* onInstanceCreated() should be called after this.instances.set(instanceIdentifier, instance); which
Expand Down