Initialize App Check debug mode in initializeAppCheck #5512
Conversation
|
Changeset File Check ✅
|
packages/app-check/src/api.ts
Outdated
| @@ -67,14 +66,13 @@ export function initializeAppCheck( | |||
| // Log a warning when `initializeAppCheck()` is called in debug mode, | |||
packages/app-check/src/api.test.ts
Outdated
| expect(consoleStub.args[0][0]).to.include(token); | ||
| self.FIREBASE_APPCHECK_DEBUG_TOKEN = undefined; | ||
| }); | ||
| it('warns about debug mode on second call', async () => { |
There was a problem hiding this comment.
What does it test?
I think we need a test to verify initializeDebugMode is called only once.
There was a problem hiding this comment.
Oh wow, the test caught the fact that I was not setting the initialize property... thanks.
|
Please add a changeset. @hsubox76 |
Initialize debug mode for App Check (i.e., reading the global var) in the first call to
initializeAppCheck()instead of when the app-check component is registered. This makes it easier for developers to set the variable in code.Additionally, it logs a
console.warnon subsequent calls to initializeAppCheck notifying the user they are still in debug mode, and logging the token (if they don't reload/quit before that token promise resolves). This may help HMR users who lose the initial token message.