Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send target to backend before local processing #5980

Merged
merged 2 commits into from
Feb 9, 2022

Conversation

schmidt-sebastian
Copy link
Contributor

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Feb 8, 2022

🦋 Changeset detected

Latest commit: d95433c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/firestore Patch
firebase Patch
@firebase/firestore-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2022

Changeset File Check ✅

  • No modified packages are missing from the changeset file.
  • No changeset formatting errors detected.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 8, 2022

Size Report 1

Affected Products

  • @firebase/firestore

    TypeBase (bf93a38)Merge (0ca8ce1)Diff
    browser231 kB231 kB+6 B (+0.0%)
    main460 kB460 kB-1 B (-0.0%)
    module231 kB231 kB+6 B (+0.0%)
    react-native231 kB231 kB+6 B (+0.0%)
  • bundle

    TypeBase (bf93a38)Merge (0ca8ce1)Diff
    firestore (Query Cursors)190 kB190 kB+6 B (+0.0%)
    firestore (Query)191 kB191 kB+6 B (+0.0%)
    firestore (Read data once)180 kB180 kB+6 B (+0.0%)
    firestore (Realtime updates)182 kB182 kB+6 B (+0.0%)
  • firebase

    TypeBase (bf93a38)Merge (0ca8ce1)Diff
    firebase-compat.js755 kB755 kB+6 B (+0.0%)
    firebase-firestore-compat.js283 kB283 kB+6 B (+0.0%)
    firebase-firestore.js780 kB780 kB+22 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/cL7Ab1vol3.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 8, 2022

Size Analysis Report 1

Affected Products

  • @firebase/firestore

    • getDoc

      Size

      TypeBase (bf93a38)Merge (0ca8ce1)Diff
      size122 kB122 kB+6 B (+0.0%)
      size-with-ext-deps172 kB172 kB+6 B (+0.0%)
    • getDocFromServer

      Size

      TypeBase (bf93a38)Merge (0ca8ce1)Diff
      size122 kB123 kB+6 B (+0.0%)
      size-with-ext-deps172 kB172 kB+6 B (+0.0%)
    • getDocs

      Size

      TypeBase (bf93a38)Merge (0ca8ce1)Diff
      size124 kB124 kB+6 B (+0.0%)
      size-with-ext-deps174 kB174 kB+6 B (+0.0%)
    • getDocsFromServer

      Size

      TypeBase (bf93a38)Merge (0ca8ce1)Diff
      size124 kB124 kB+6 B (+0.0%)
      size-with-ext-deps174 kB174 kB+6 B (+0.0%)
    • onSnapshot

      Size

      TypeBase (bf93a38)Merge (0ca8ce1)Diff
      size125 kB125 kB+6 B (+0.0%)
      size-with-ext-deps175 kB175 kB+6 B (+0.0%)
    • onSnapshotsInSync

      Size

      TypeBase (bf93a38)Merge (0ca8ce1)Diff
      size114 kB114 kB+6 B (+0.0%)
      size-with-ext-deps164 kB164 kB+6 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/1ncTGDR4s0.html

@wu-hui wu-hui merged commit e961968 into master Feb 9, 2022
@wu-hui wu-hui deleted the mrschmidt/addtargetfirst branch February 9, 2022 19:38
@google-oss-bot google-oss-bot mentioned this pull request Feb 16, 2022
@firebase firebase locked and limited conversation to collaborators Mar 12, 2022
@dconeybe
Copy link
Contributor

Note: This optimization is effectively reverted by #7229. This is because the number of documents that match the query in the local cache is now part of the request sent to the server, and, therefore, must be calculated before the request is sent to the server.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants