Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add expectedCount to Target in listen request #6854

Merged
merged 17 commits into from
Jan 6, 2023
Merged

Add expectedCount to Target in listen request #6854

merged 17 commits into from
Jan 6, 2023

Conversation

milaGGL
Copy link
Contributor

@milaGGL milaGGL commented Dec 5, 2022 •
edited
Loading

  • add expectedCount to Target
  • add expectedCount to spec test builder without exploding current tests.
    --spec builders affected: userListens, restoreListen, expectListen, expectActiveTargets
  • add simple spec tests to make sure the expectedCount parameter is working as expected

@changeset-bot
Copy link

changeset-bot bot commented Dec 5, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: cef7db7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 5, 2022 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/firestore

    TypeBase (036849f)Merge (49e3609)Diff
    browser273 kB273 kB+543 B (+0.2%)
    esm5339 kB340 kB+580 B (+0.2%)
    main545 kB546 kB+742 B (+0.1%)
    module273 kB273 kB+543 B (+0.2%)
    react-native273 kB273 kB+543 B (+0.2%)

  • bundle

    TypeBase (036849f)Merge (49e3609)Diff
    firestore (Persistence)292 kB292 kB+549 B (+0.2%)
    firestore (Query Cursors)230 kB231 kB+543 B (+0.2%)
    firestore (Query)228 kB229 kB+543 B (+0.2%)
    firestore (Read data once)215 kB216 kB+543 B (+0.3%)
    firestore (Realtime updates)217 kB218 kB+543 B (+0.2%)

  • firebase

    TypeBase (036849f)Merge (49e3609)Diff
    firebase-compat.js756 kB757 kB+542 B (+0.1%)
    firebase-firestore-compat.js331 kB331 kB+542 B (+0.2%)
    firebase-firestore.js332 kB332 kB+543 B (+0.2%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/azWv0dk0A1.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 5, 2022 •
edited
Loading

Size Analysis Report 1

Affected Products

  • @firebase/firestore

    • enableIndexedDbPersistence

      Size

      TypeBase (036849f)Merge (49e3609)Diff
      size179 kB179 kB+240 B (+0.1%)
      size-with-ext-deps250 kB250 kB+240 B (+0.1%)

    • enableMultiTabIndexedDbPersistence

      Size

      TypeBase (036849f)Merge (49e3609)Diff
      size211 kB212 kB+548 B (+0.3%)
      size-with-ext-deps283 kB283 kB+549 B (+0.2%)

    • getDoc

      Size

      TypeBase (036849f)Merge (49e3609)Diff
      size135 kB135 kB+542 B (+0.4%)
      size-with-ext-deps205 kB205 kB+543 B (+0.3%)

    • getDocFromServer

      Size

      TypeBase (036849f)Merge (49e3609)Diff
      size135 kB135 kB+542 B (+0.4%)
      size-with-ext-deps205 kB205 kB+543 B (+0.3%)

    • getDocs

      Size

      TypeBase (036849f)Merge (49e3609)Diff
      size137 kB137 kB+542 B (+0.4%)
      size-with-ext-deps207 kB207 kB+543 B (+0.3%)

    • getDocsFromServer

      Size

      TypeBase (036849f)Merge (49e3609)Diff
      size136 kB137 kB+542 B (+0.4%)
      size-with-ext-deps206 kB207 kB+543 B (+0.3%)

    • loadBundle

      Size

      TypeBase (036849f)Merge (49e3609)Diff
      size107 kB107 kB+240 B (+0.2%)
      size-with-ext-deps177 kB177 kB+240 B (+0.1%)

    • onSnapshot

      Size

      TypeBase (036849f)Merge (49e3609)Diff
      size137 kB138 kB+542 B (+0.4%)
      size-with-ext-deps207 kB208 kB+543 B (+0.3%)

    • onSnapshotsInSync

      Size

      TypeBase (036849f)Merge (49e3609)Diff
      size127 kB127 kB+542 B (+0.4%)
      size-with-ext-deps197 kB197 kB+543 B (+0.3%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/zMfICkdSDs.html

@milaGGL milaGGL changed the base branch from mila/BloomFilter to master December 6, 2022 04:01
@milaGGL milaGGL changed the base branch from master to mila/BloomFilter December 6, 2022 04:01
@milaGGL milaGGL changed the base branch from mila/BloomFilter to master December 6, 2022 04:02
@milaGGL milaGGL changed the base branch from master to mila/BloomFilter December 6, 2022 17:48
@milaGGL milaGGL marked this pull request as ready for review December 13, 2022 19:01
@milaGGL milaGGL requested a review from dconeybe December 13, 2022 19:50
dconeybe
dconeybe requested changes Dec 21, 2022
View reviewed changes
Copy link
Contributor

@dconeybe dconeybe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! I'm still diving into some of the details, but at a high level it looks great. Here is my first round of feedback.

packages/firestore/src/local/target_data.ts Outdated Show resolved Hide resolved
packages/firestore/src/local/target_data.ts Outdated Show resolved Hide resolved
packages/firestore/src/local/target_data.ts Outdated Show resolved Hide resolved
packages/firestore/src/core/sync_engine_impl.ts Show resolved Hide resolved
packages/firestore/src/local/target_data.ts Outdated Show resolved Hide resolved
packages/firestore/test/unit/specs/spec_builder.ts Outdated Show resolved Hide resolved
packages/firestore/test/unit/specs/spec_builder.ts Outdated Show resolved Hide resolved
packages/firestore/test/unit/specs/spec_builder.ts Outdated Show resolved Hide resolved
packages/firestore/test/unit/specs/spec_builder.ts Outdated Show resolved Hide resolved
@milaGGL milaGGL requested a review from dconeybe December 21, 2022 19:34
dconeybe
dconeybe requested changes Dec 21, 2022
View reviewed changes
Copy link
Contributor

@dconeybe dconeybe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor comments, then LGTM!

packages/firestore/src/local/target_data.ts Show resolved Hide resolved
packages/firestore/test/unit/specs/listen_spec.test.ts Outdated Show resolved Hide resolved
packages/firestore/test/unit/specs/listen_spec.test.ts Outdated Show resolved Hide resolved
packages/firestore/test/unit/specs/listen_spec.test.ts Outdated Show resolved Hide resolved
@milaGGL milaGGL requested a review from dconeybe December 22, 2022 20:59
dconeybe
dconeybe requested changes Jan 5, 2023
View reviewed changes
Copy link
Contributor

@dconeybe dconeybe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few more very minor comments.

packages/firestore/src/local/target_data.ts Outdated Show resolved Hide resolved
packages/firestore/src/local/target_data.ts Outdated Show resolved Hide resolved
packages/firestore/test/unit/specs/listen_spec.test.ts Outdated Show resolved Hide resolved
packages/firestore/test/unit/specs/listen_spec.test.ts Outdated Show resolved Hide resolved
packages/firestore/test/unit/specs/spec_builder.ts Outdated Show resolved Hide resolved
@milaGGL milaGGL requested a review from dconeybe January 6, 2023 00:57
@milaGGL milaGGL merged commit 9e49b4c into mila/BloomFilter Jan 6, 2023
@milaGGL milaGGL deleted the mila/BloomFilter-add-expectedCount-to-Target branch January 6, 2023 16:58
@milaGGL milaGGL self-assigned this Jan 13, 2023
@milaGGL milaGGL mentioned this pull request Jan 19, 2023
Merged
@firebase firebase locked and limited conversation to collaborators Feb 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dconeybe dconeybe dconeybe approved these changes

Assignees

@milaGGL milaGGL

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@milaGGL @google-oss-bot @dconeybe