Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix expectedCount encoding in grpc #7087

Merged
merged 3 commits into from
Mar 3, 2023
Merged

Fix expectedCount encoding in grpc #7087

merged 3 commits into from
Mar 3, 2023

Conversation

dconeybe
Copy link
Contributor

@dconeybe dconeybe commented Mar 2, 2023

No description provided.

@dconeybe dconeybe self-assigned this Mar 2, 2023
@changeset-bot
Copy link

changeset-bot bot commented Mar 2, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 8ae6f1d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 2, 2023 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/firestore

    TypeBase (8a5faad)Merge (dafecbb)Diff
    browser277 kB277 kB-3 B (-0.0%)
    esm5345 kB345 kB-2 B (-0.0%)
    main553 kB554 kB+343 B (+0.1%)
    module277 kB277 kB-3 B (-0.0%)
    react-native278 kB278 kB-3 B (-0.0%)

  • bundle

    TypeBase (8a5faad)Merge (dafecbb)Diff
    firestore (Persistence)295 kB295 kB-3 B (-0.0%)
    firestore (Query Cursors)233 kB233 kB-3 B (-0.0%)
    firestore (Query)231 kB231 kB-3 B (-0.0%)
    firestore (Read data once)219 kB219 kB-3 B (-0.0%)
    firestore (Realtime updates)221 kB221 kB-3 B (-0.0%)

  • firebase

    TypeBase (8a5faad)Merge (dafecbb)Diff
    firebase-compat.js761 kB761 kB+16 B (+0.0%)
    firebase-firestore-compat.js334 kB334 kB+16 B (+0.0%)
    firebase-firestore.js337 kB337 kB-3 B (-0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/zHZRnagygk.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 2, 2023 •
edited
Loading

Size Analysis Report 1

This report is too large (435,772 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/AK0FFgyuoZ.html

@dconeybe dconeybe requested a review from milaGGL March 2, 2023 20:29
milaGGL
milaGGL approved these changes Mar 3, 2023
View reviewed changes
Copy link
Contributor

@milaGGL milaGGL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dconeybe dconeybe merged commit 65e5452 into mila/BloomFilter Mar 3, 2023
@dconeybe dconeybe deleted the dconeybe/ExpectedCountProtoFix branch March 3, 2023 02:04
@firebase firebase locked and limited conversation to collaborators Apr 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@milaGGL milaGGL milaGGL approved these changes

Assignees

@dconeybe dconeybe

Labels
api: firestore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dconeybe @google-oss-bot @milaGGL