Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'existence-filter-mismatch-bloom' to listen request labels and test with spec tests #7107

Merged
merged 5 commits into from
Mar 9, 2023
Merged

Add 'existence-filter-mismatch-bloom' to listen request labels and test with spec tests #7107

merged 5 commits into from
Mar 9, 2023

Conversation

milaGGL
Copy link
Contributor

@milaGGL milaGGL commented Mar 8, 2023

No description provided.

@milaGGL milaGGL self-assigned this Mar 8, 2023
@changeset-bot
Copy link

changeset-bot bot commented Mar 8, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: f90ab2e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@milaGGL milaGGL changed the title initial code Add 'existence-filter-mismatch-bloom' to listen request labels and test with spec tests Mar 8, 2023
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 9, 2023 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/firestore

    TypeBase (465e8df)Merge (a4b69fc)Diff
    browser278 kB278 kB+122 B (+0.0%)
    esm5345 kB345 kB+108 B (+0.0%)
    main555 kB555 kB+141 B (+0.0%)
    module278 kB278 kB+122 B (+0.0%)
    react-native278 kB278 kB+122 B (+0.0%)

  • bundle

    TypeBase (465e8df)Merge (a4b69fc)Diff
    firestore (Persistence)296 kB296 kB+122 B (+0.0%)
    firestore (Query Cursors)234 kB234 kB+122 B (+0.1%)
    firestore (Query)231 kB232 kB+122 B (+0.1%)
    firestore (Read data once)219 kB219 kB+122 B (+0.1%)
    firestore (Realtime updates)221 kB221 kB+122 B (+0.1%)

  • firebase

    TypeBase (465e8df)Merge (a4b69fc)Diff
    firebase-compat.js761 kB761 kB+120 B (+0.0%)
    firebase-firestore-compat.js335 kB335 kB+120 B (+0.0%)
    firebase-firestore.js337 kB337 kB+114 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/vFNTIMFBv5.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 9, 2023 •
edited
Loading

Size Analysis Report 1

This report is too large (96,162 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/EFiH0KKvl0.html

@milaGGL milaGGL marked this pull request as ready for review March 9, 2023 18:15
@milaGGL milaGGL requested a review from dconeybe March 9, 2023 18:15
dconeybe
dconeybe requested changes Mar 9, 2023
View reviewed changes
packages/firestore/src/local/local_store_impl.ts Outdated Show resolved Hide resolved
packages/firestore/src/local/target_data.ts Outdated Show resolved Hide resolved
packages/firestore/src/remote/bloom_filter.ts Outdated Show resolved Hide resolved
packages/firestore/test/unit/remote/remote_event.test.ts Show resolved Hide resolved
@milaGGL milaGGL requested a review from dconeybe March 9, 2023 21:21
dconeybe
dconeybe approved these changes Mar 9, 2023
View reviewed changes
Copy link
Contributor

@dconeybe dconeybe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! With one tiny nit of a comment :)

packages/firestore/test/unit/remote/remote_event.test.ts Outdated
@@ -431,6 +431,9 @@ describe('RemoteEvent', () => {
expectTargetChangeEquals(event.targetChanges.get(1)!, expected);
});

// TODO(Mila): Add test cases for existence filter with bloom filter, one will
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Put b/272564458 in the "TODO" rather than "Mila".

@milaGGL milaGGL merged commit 5c2ec00 into mila/BloomFilter Mar 9, 2023
@milaGGL milaGGL deleted the mila/BloomFilter-add-new-goog-listen-tag branch March 9, 2023 23:34
@milaGGL milaGGL mentioned this pull request Mar 13, 2023
Merged
@milaGGL milaGGL mentioned this pull request Mar 24, 2023
Merged
@firebase firebase locked and limited conversation to collaborators Apr 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dconeybe dconeybe dconeybe approved these changes

Assignees

@milaGGL milaGGL

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@milaGGL @google-oss-bot @dconeybe