Recaptcha public preview #7193
Merged
Recaptcha public preview #7193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f4cff13 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1This report is too large (408,523 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.Test Logs |
added 4 commits
April 3, 2023 17:15
…e/firebase-js-sdk into recaptcha-public-preview
renkelvin
requested review from
egilmorez,
markarndt,
lisajian,
prameshj,
sam-gc,
dwyfrequency and
hsubox76
as code owners
|
Hey @kevinthecheung, this pr is to merge the recaptcha enterprise integration from the feature branch to main. The code changes have been reviewed separately, could you help review the docs part? Thanks! CI failure seems not related to this PR. Still investigating. |
Co-authored-by: Kevin Cheung <kevinthecheung@users.noreply.github.com>
…e/firebase-js-sdk into recaptcha-public-preview
Co-authored-by: Kevin Cheung <kevinthecheung@users.noreply.github.com>
Co-authored-by: Kevin Cheung <kevinthecheung@users.noreply.github.com>
renkelvin
changed the title
prameshj
reviewed
Apr 10, 2023
| signUpResponse = signUp(authInternal, requestWithRecaptcha); | ||
| } else { | ||
| signUpResponse = signUp(authInternal, request).catch(async error => { | ||
| if (error.code === `auth/${AuthErrorCode.MISSING_RECAPTCHA_TOKEN}`) { |
There was a problem hiding this comment.
not blocking this release - we should consider unifying this logic in a single util method somewhere, to which we can pass the action type. That way we implement it once and make enhancements in one place only.
packages/auth/src/platform_browser/recaptcha/recaptcha_enterprise_verifier.ts
Outdated
Show resolved
Hide resolved
packages/auth/src/platform_browser/recaptcha/recaptcha_enterprise_verifier.ts
Show resolved
Hide resolved
hsubox76
reviewed
Apr 11, 2023
There was a problem hiding this comment.
- Approved for the api.md.
- Make sure to add a changeset (@firebase/auth minor, firebase minor).
- This is the PR that will be traced back to from the changeset and release notes so can you add a description, even if it just points to other PRs that went into this one that have a more detailed description? Maybe a link to the API proposal/design doc (you can say "(internal link)" after it).
Done. |
prameshj
reviewed
Apr 11, 2023
hsubox76
approved these changes
Apr 11, 2023
prameshj
approved these changes
Apr 11, 2023
|
@hsubox76 Seems I don't have the permission to merge this RP. |
I think it's due to approval not being granted by @kevinthecheung after leaving comments. |
kevinthecheung
approved these changes
Apr 12, 2023
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add the support of reCAPTCHA enterprise integration to GCIP / Firebase Auth. For more details, see go/gcip-recaptcha, go/gcip-recaptcha-client-sdk-api (internal linlks).