Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gcEnabled for multitab test #7234

Merged
merged 48 commits into from
Apr 19, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
48 commits
Select commit Hold shift + click to select a range
e8b53c6
Initial implementation
wu-hui Jan 4, 2023
3a922f1
Add spec tests for LRU GC
wu-hui Jan 11, 2023
107a051
lint
wu-hui Jan 11, 2023
14ed4f3
Update API reports
wu-hui Jan 11, 2023
7b9d18d
Spec test clean up
wu-hui Jan 12, 2023
2ea1fad
Fix error and polishing.
wu-hui Jan 12, 2023
92b1cac
Fix a build error
wu-hui Jan 12, 2023
4ed6691
New way to config Firestore SDK Cache.
wu-hui Feb 8, 2023
48d5077
fixups
wu-hui Feb 9, 2023
7d0b186
Fix some test failures
wu-hui Feb 9, 2023
d651d88
Fixing dts file
wu-hui Feb 21, 2023
880bd55
Fixing integration tests
wu-hui Feb 28, 2023
c36e96f
rename file
wu-hui Feb 28, 2023
85ea128
Increase cache size threshold
wu-hui Feb 28, 2023
28215da
Add public comments
wu-hui Mar 1, 2023
36715cd
API report
wu-hui Mar 1, 2023
4bbcbe1
Create brown-beers-tease.md
wu-hui Mar 1, 2023
3d22995
warning messages and more tests
wu-hui Mar 1, 2023
5b16efd
Addressing comments
wu-hui Mar 2, 2023
2b9d3b8
Merge branch 'wuandy/NewCacheConfig' into wuandy/LruGC
wu-hui Mar 2, 2023
89f78c7
Update API reports
wu-hui Mar 2, 2023
93738f3
new lru gc api
wu-hui Mar 2, 2023
1d5c82f
Fix provider test failure for node w/o indexeddb
wu-hui Mar 2, 2023
04f85ab
Fix node memory test
wu-hui Mar 2, 2023
e53ae7f
Merge branch 'wuandy/NewCacheConfig' into wuandy/LruGC
wu-hui Mar 3, 2023
2489fc6
linting and exporting
wu-hui Mar 3, 2023
70b742f
rename cache to localCache
wu-hui Mar 3, 2023
95f537e
Update API reports
wu-hui Mar 3, 2023
a49b8a5
Tech writer review
wu-hui Mar 6, 2023
bb616a8
Merge branch 'wuandy/NewCacheConfig' into wuandy/LruGC
wu-hui Mar 6, 2023
0c1c12e
yarn docgen
wu-hui Mar 6, 2023
1d0af2e
Merge branch 'wuandy/NewCacheConfig' into wuandy/LruGC
wu-hui Mar 6, 2023
de64910
Merge branch 'master' into wuandy/LruGC
wu-hui Mar 17, 2023
9771e74
Fix merge error and re-build devsite
wu-hui Mar 17, 2023
f05a45e
lint and prettier
wu-hui Mar 17, 2023
57c64c7
Merge branch 'master' into wuandy/LruGC
wu-hui Mar 22, 2023
faf7aca
Merge branch 'master' into wuandy/LruGC
wu-hui Apr 12, 2023
8e62300
Update API reports
wu-hui Apr 12, 2023
b83a723
addressing feedback
wu-hui Apr 17, 2023
6e5767d
Merge branch 'master' into wuandy/LruGC
wu-hui Apr 17, 2023
c20f61f
docsite
wu-hui Apr 17, 2023
68e2f21
review auth.api.md
wu-hui Apr 17, 2023
5303e16
Update API reports
wu-hui Apr 17, 2023
5bf4ec8
changeset and revert auth changes
wu-hui Apr 17, 2023
fc4bb55
fix error message
wu-hui Apr 17, 2023
85483bf
minor bump
wu-hui Apr 18, 2023
4f81d93
Remove gcEnabled for multab test
wu-hui Apr 19, 2023
57a5616
Merge branch 'master' into wuandy/LruGC
wu-hui Apr 19, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/firestore/test/unit/specs/limbo_spec.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -425,7 +425,7 @@ describeSpec('Limbo Documents:', [], () => {
const docB = doc('collection/b', 1001, { key: 'b' });
const deletedDocB = deletedDoc('collection/b', 1005);

return client(0, false)
return client(0)
.expectPrimaryState(true)
.client(1)
.userListens(query1)
Expand Down Expand Up @@ -463,7 +463,7 @@ describeSpec('Limbo Documents:', [], () => {
const deletedDocB = deletedDoc('collection/b', 1006);
const deletedDocC = deletedDoc('collection/c', 1008);

return client(0, false)
return client(0)
.expectPrimaryState(true)
.userListens(query1)
.watchAcksFull(query1, 1 * 1e6, docA, docB, docC)
Expand Down
6 changes: 3 additions & 3 deletions packages/firestore/test/unit/specs/listen_spec.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -845,7 +845,7 @@ describeSpec('Listens:', [], () => {
const docA = doc('collection/a', 1000, { key: 'a' });
const docB = doc('collection/b', 2000, { key: 'a' });

return client(0, /* withGcEnabled= */ false)
return client(0)
.becomeVisible()
.client(1)
.userListens(query1)
Expand Down Expand Up @@ -1754,7 +1754,7 @@ describeSpec('Listens:', [], () => {
() => {
const query1 = query('collection');
return (
client(0, /* withGcEnabled= */ false)
client(0)
// Populate the cache with the empty query results.
.userListens(query1)
.watchAcksFull(query1, 1000)
Expand Down Expand Up @@ -1785,7 +1785,7 @@ describeSpec('Listens:', [], () => {
const doc1Deleted = deletedDoc('collection/a', 2000);

return (
client(0, /* withGcEnabled= */ false)
client(0)
// Populate the cache with the empty query results.
.userListens(query1)
.watchAcksFull(query1, 1000, doc1)
Expand Down
5 changes: 1 addition & 4 deletions packages/firestore/test/unit/specs/spec_builder.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1252,10 +1252,7 @@ export function spec(): SpecBuilder {

/** Starts a new multi-client SpecTest. */
// PORTING NOTE: Only used by web multi-tab tests.
export function client(
num: number,
withGcEnabled?: boolean
): MultiClientSpecBuilder {
export function client(num: number): MultiClientSpecBuilder {
const specBuilder = new MultiClientSpecBuilder();
specBuilder.ensureManualLruGC();
return specBuilder.client(num);
Expand Down